Skip to content

Fix README_JA.md #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2023
Merged

Fix README_JA.md #810

merged 2 commits into from
Dec 14, 2023

Conversation

tegnike
Copy link
Contributor

@tegnike tegnike commented Dec 3, 2023

Describe the changes you have made:

  • Fix README_JA.md

  • I have performed a self-review of my code:

I have tested the code on the following OS:

  • no need

AI Language Model (if applicable)

  • no need

@Notnaton
Copy link
Collaborator

Notnaton commented Dec 7, 2023

We seem to have two PRs for the same file, can you guys work together to bring this into one PR?
#820
#810

@Notnaton Notnaton mentioned this pull request Dec 7, 2023
Closed
10 tasks
ShEGUCHI
ShEGUCHI reviewed Dec 8, 2023
View reviewed changes
Copy link

@ShEGUCHI ShEGUCHI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read the contents. It was in line with the new README.
Thank you.

@tegnike
Copy link
Contributor Author

tegnike commented Dec 8, 2023

Thanks @ShEGUCHI !!

@Notnaton
When you have time, please mearge this #810. And close #820.

@Notnaton Notnaton added the Documentation Improvements or additions to documentation label Dec 8, 2023
@KillianLucas
Copy link
Collaborator

Excellent work @tegnike, this is so helpful to have your edits to OI's Japanese communications. I have no way of improving that half of things, yet (behind English speakers) they're our biggest community by far.

And many thanks @ShEGUCHI for also submitting a PR and reviewing this one. Merging now!

@KillianLucas KillianLucas merged commit ac1e4bc into openinterpreter:main Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ShEGUCHI ShEGUCHI ShEGUCHI left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@KillianLucas KillianLucas

Labels
Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tegnike @Notnaton @KillianLucas @ShEGUCHI