Skip to content

Conversation

ShEGUCHI
Copy link

@ShEGUCHI ShEGUCHI commented Dec 6, 2023

Describe the changes you have made:

Update only docs/README_JA.md (marge README.md)

Reference any relevant issue (Fixes #000)

  • I have performed a self-review of my code:

I have tested the code on the following OS:

  • Windows
  • MacOS
  • Linux

AI Language Model (if applicable)

  • GPT4
  • GPT3
  • Llama 7B
  • Llama 13B
  • Llama 34B
  • Huggingface model (Please specify which one)

@Notnaton Notnaton mentioned this pull request Dec 7, 2023
1 task
@Notnaton
Copy link
Collaborator

Notnaton commented Dec 7, 2023

We seem to have two PRs for the same file, can you guys work together to bring this into one PR?
#820
#810

@tegnike
Copy link
Contributor

tegnike commented Dec 7, 2023

@Notnaton @ShEGUCHI

I can review this PR instead of mine.

And actually one more here... #483
I realized it after I made my PR.

But it's updated with old README, so I'll try to fix this PR.

@tegnike
Copy link
Contributor

tegnike commented Dec 7, 2023

@ShEGUCHI
I read your updated.
Hmm... it's difficult comparing READMEs, because we do the best to translate it each other.
Please read mine #810. if you think #820 better, I'll follow you.

@ShEGUCHI
Copy link
Author

ShEGUCHI commented Dec 7, 2023

Thank you for confirmation.
There was something else.

I don't need mine.

regards.

@tegnike
Copy link
Contributor

tegnike commented Dec 7, 2023

@ShEGUCHI

ok, thanks for reply.
And if you have time, it would be helpful if you could review #810.

@ShEGUCHI
Copy link
Author

ShEGUCHI commented Dec 7, 2023

I've got it :-)

@Notnaton
Copy link
Collaborator

Notnaton commented Dec 8, 2023

Closing this in favor of #810

@Notnaton Notnaton closed this Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants