Skip to content

[windows] Add Windows compatibility for the replacement ESBuild plugin #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

costinsin
Copy link
Contributor

Previously, the separator for the filter regex was hardcoded to / (Unix separator).

Now, we're also taking account for the \ (Windows separator) in the filter regex.

Previously, the separator for the filter regex was hardcoded to / (Unix separator).

Now, we're also taking account for the \ (Windows separator) in the filter regex.

Signed-off-by: Costin-Robert Sin <[email protected]>
Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 0115853

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
open-next Patch
app-pages-router Patch
app-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 5:58pm

Copy link
Contributor

@khuezy khuezy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create a utils function to handle this.
eg:
toTarget('/core/util.js)` would generate the regex w/ forward and backslash.

While you're here improving windows support, we should add windows to the e2e test matrix.

@costinsin
Copy link
Contributor Author

costinsin commented Jul 8, 2024

I agree with both of your suggestions. However, I think these 2 improvements should be done in following PRs as currently this "regex change" is split in 2 PRs (this and #461) and I would firstly merge those and then do the toTarget change.

What do you think about this?

@khuezy
Copy link
Contributor

khuezy commented Jul 8, 2024

Sounds good to me.

@conico974 conico974 merged commit 7beaf82 into opennextjs:main Jul 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants