Skip to content

windows support #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
james-elicx opened this issue Jan 8, 2025 · 4 comments · Fixed by #247
Closed

windows support #236

james-elicx opened this issue Jan 8, 2025 · 4 comments · Fixed by #247
Assignees

Comments

@james-elicx
Copy link
Collaborator

james-elicx commented Jan 8, 2025

Reports from various people/channels that Windows has issues.

  • figure out (investigate) what the problem areas are
  • fix issues that come up
  • update docs where applicable
@james-elicx james-elicx self-assigned this Jan 8, 2025
@james-elicx james-elicx converted this from a draft issue Jan 8, 2025
@dario-piotrowicz
Copy link
Contributor

The opennextjs-aws code we rely on already doesn't seem to fully support windows, at least according to this warning.

@conico974 do you have more context/info to provide regarding that? do you know what makes the aws adapter not windows-compatible (is there anything specific, some general issue, etc...)?

@conico974
Copy link
Collaborator

Honestly i haven't touched windows at all for OpenNext, but i knew of a few issues

It should work now, but since i haven't worked on this we just kept the warning

@james-elicx
Copy link
Collaborator Author

Thanks for the PR links. Fully enough, I actually had one of them open already :)

Had to update some of the esbuild filters in opennextjs/opennextjs-aws#695 as you suspected. There were a couple of paths that needed normalizing on our side as well.

@dario-piotrowicz
Copy link
Contributor

Thanks a bunch @conico974 for the info (sorry for the late reply I only now noticed your comment), I see, the situation is kinda like I suspected (Next not being fully there and us not testing/investing into it).

I'd personally be fine keeping the warning although I think it could be great if we could maybe document this more, at least for visibility/transparency (basically something like your comment but in a docs format)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants