-
Notifications
You must be signed in to change notification settings - Fork 541
NO-JIRA: Promote ExternalOIDCWithUIDAndExtraClaimMappings
feature to GA for Hypershift
#2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
NO-JIRA: Promote ExternalOIDCWithUIDAndExtraClaimMappings
feature to GA for Hypershift
#2274
Conversation
Skipping CI for Draft Pull Request. |
Hello @everettraven! Some important instructions when contributing to openshift/api: |
Depends on #2234 /hold |
a2cb505
to
6d7dc70
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: everettraven The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ExternalOIDCWithUIDAndExtraClaimMappings
feature to GA for HypershiftExternalOIDCWithUIDAndExtraClaimMappings
feature to GA for Hypershift
This feature gate promotion will not pass the standard feature gate promotion criteria but is being proposed for promotion due to a critical need for this feature in HyperShift. Holding until we have the necessary discussions, with the appropriate stakeholders, to determine if the risks associated with promoting this feature to GA in HyperShift are acceptable. /hold |
ExternalOIDCWithUIDAndExtraClaimMappings
feature to GA for HypershiftExternalOIDCWithUIDAndExtraClaimMappings
feature to GA for Hypershift
@everettraven: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
6d7dc70
to
d6ce029
Compare
/retest |
1 similar comment
/retest |
d6ce029
to
48588a4
Compare
/retest |
@everettraven: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Pre-merge test the opening #2274 , openshift/hypershift#6025 without techpreviewnoupgrade, no regression issue, and with byo oidc with uid and extra field function well. |
No description provided.