Skip to content

Promote BYO OIDC features #2454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Promote BYO OIDC features #2454

wants to merge 1 commit into from
+15 −10,529

Conversation

everettraven
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

Hello @everettraven! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@everettraven everettraven mentioned this pull request Aug 18, 2025
Closed
@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 18, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed August 18, 2025 15:31
JoelSpeed
JoelSpeed reviewed Aug 19, 2025
View reviewed changes
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

3 similar comments
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2025
@everettraven
promote BYO OIDC features
bee65eb 
Signed-off-by: Bryce Palmer <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@everettraven everettraven mentioned this pull request Sep 11, 2025
Closed
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven everettraven mentioned this pull request Sep 16, 2025
Open
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

6 similar comments
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@liouk
Copy link
Member

liouk commented Sep 23, 2025

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@liouk
Copy link
Member

liouk commented Sep 24, 2025

/test verify-feature-promotion

@everettraven everettraven changed the title WIP: Promote BYO OIDC features Promote BYO OIDC features Sep 24, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2025
@liouk
Copy link
Member

liouk commented Sep 25, 2025

/test verify-feature-promotion

1 similar comment
@everettraven
Copy link
Contributor Author

/test verify-feature-promotion

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 25, 2025

@everettraven: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-out-of-change bee65eb link true /test e2e-upgrade-out-of-change
ci/prow/e2e-aws-ovn-hypershift-conformance bee65eb link true /test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-serial-techpreview-2of2 bee65eb link true /test e2e-aws-serial-techpreview-2of2
ci/prow/verify-feature-promotion bee65eb link true /test verify-feature-promotion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

1 more reviewer

@JoelSpeed JoelSpeed JoelSpeed left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@everettraven @liouk @JoelSpeed @openshift-merge-robot