Skip to content

STOR-2533,OCPBUGS-61382: move VolumeAttributesClass to GA #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2025
Merged

STOR-2533,OCPBUGS-61382: move VolumeAttributesClass to GA #2471

merged 1 commit into from
Oct 2, 2025
+8 −8

Conversation

dfajmon
Copy link
Contributor

@dfajmon dfajmon commented Sep 9, 2025

As we are GAing the VolumeAttributesClass, I'm updating them to fix the issue with the tests

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 9, 2025

Hello @dfajmon! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot
Copy link

@dfajmon: This pull request references Jira Issue OCPBUGS-61382, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

As we are GAing the VolumeAttributesClass, I'm updating them to fix the issue with the tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 9, 2025
@dfajmon dfajmon force-pushed the volumeattributesclass branch from cb556e0 to 0846c5a Compare September 9, 2025 12:44
@JoelSpeed
Copy link
Contributor

Code generation is out of date here, please rebase on the latest master and re-run the generation

@dfajmon dfajmon force-pushed the volumeattributesclass branch from 0846c5a to 3f69da8 Compare September 9, 2025 14:10
@dfajmon dfajmon changed the title OCPBUGS-61382: move VolumeAttributesClass to GA STOR-2533,OCPBUGS-61382: move VolumeAttributesClass to GA Sep 11, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2025 •
edited by openshift-ci bot
Loading

@dfajmon: This pull request references STOR-2533 which is a valid jira issue.

This pull request references Jira Issue OCPBUGS-61382, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

As we are GAing the VolumeAttributesClass, I'm updating them to fix the issue with the tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 11, 2025
@JoelSpeed
Copy link
Contributor

/test verify-feature-promotion

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 11, 2025

@JoelSpeed I don't think this will come through the necessary checks for promotion at the moment.
There are flaky tests which will be fixed with openshift/kubernetes#2452 after it merges

@JoelSpeed
Copy link
Contributor

@JoelSpeed I don't think this will come through the necessary checks for promotion at the moment. There are flaky tests which will be fixed with openshift/kubernetes#2452 after it merges

No problem, I see three lanes where there are issues currently, was just curious how close we were. Ping me on slack when you think this is good to go

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 16, 2025

/retest-required

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 21, 2025

/retest

@JoelSpeed
Copy link
Contributor

I can see that verify is just one test off, I'll tag this and then it can be merged once the verify goes green

/lgtm
/verified by feature promotion checks

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 22, 2025
@openshift-ci-robot
Copy link

@JoelSpeed: This PR has been marked as verified by feature promotion checks.

In response to this:

I can see that verify is just one test off, I'll tag this and then it can be merged once the verify goes green

/lgtm
/verified by feature promotion checks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2025
@openshift-ci-robot
Copy link

/test remaining-required

Scheduling tests matching the pipeline_run_if_changed parameter:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bc748ef and 2 for PR HEAD 3f69da8 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 04f99ea and 1 for PR HEAD 3f69da8 in total

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 25, 2025

/retest-required

3 similar comments
@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 25, 2025

/retest-required

@jacobsee
Copy link
Member

/retest-required

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 26, 2025

/retest-required

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 26, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 1517fca and 2 for PR HEAD 3f69da8 in total

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 28, 2025

/retest-required

4 similar comments
@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 29, 2025

/retest-required

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 29, 2025

/retest-required

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 29, 2025

/retest-required

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 30, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7f24529 and 1 for PR HEAD 3f69da8 in total

@dfajmon
Copy link
Contributor Author

dfajmon commented Sep 30, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fa7b372 and 0 for PR HEAD 3f69da8 in total

@jacobsee
Copy link
Member

jacobsee commented Oct 1, 2025

/retest-required

@openshift-ci-robot
Copy link

/hold

Revision 3f69da8 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 1, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2025
@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 1, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bfcb56b and 2 for PR HEAD 3f69da8 in total

@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 2, 2025

/retest

2 similar comments
@bertinatto
Copy link
Member

/retest

@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 2, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 2, 2025

@dfajmon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfajmon
Copy link
Contributor Author

dfajmon commented Oct 2, 2025

finally
/this-is-fine

@openshift-merge-bot openshift-merge-bot bot merged commit 230d0e0 into openshift:master Oct 2, 2025
28 checks passed
@openshift-ci-robot
Copy link

@dfajmon: Jira Issue Verification Checks: Jira Issue OCPBUGS-61382
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-61382 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

As we are GAing the VolumeAttributesClass, I'm updating them to fix the issue with the tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.21.0-0.nightly-2025-10-02-215712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven Awaiting requested review from everettraven

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dfajmon @openshift-ci-robot @JoelSpeed @jacobsee @bertinatto @openshift-merge-robot