Skip to content

Conversation

dfajmon
Copy link

@dfajmon dfajmon commented Sep 9, 2025

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Fix an issue in the test where a PersistentVolume (PV) was marked for deletion, but the test subsequently set its status back to Available, preventing the PV from being deleted.

Does this PR introduce a user-facing change?

None

@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 9, 2025
@openshift-ci-robot
Copy link

@dfajmon: This pull request references Jira Issue OCPBUGS-61382, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Fix an issue in the test where a PersistentVolume (PV) was marked for deletion, but the test subsequently set its status back to Available, preventing the PV from being deleted.

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 9, 2025
@openshift-ci-robot
Copy link

@dfajmon: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the kind/flake Categorizes issue or PR as related to a flaky test. label Sep 9, 2025
@dfajmon dfajmon changed the title OCPBUGS-61382: Do not remove PVC ClaimRef to fix flaky VAC test OCPBUGS-61222: Do not remove PVC ClaimRef to fix flaky VAC test Sep 9, 2025
@openshift-ci-robot
Copy link

@dfajmon: This pull request references Jira Issue OCPBUGS-61222, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Fix an issue in the test where a PersistentVolume (PV) was marked for deletion, but the test subsequently set its status back to Available, preventing the PV from being deleted.

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfajmon
Copy link
Author

dfajmon commented Sep 10, 2025

/retest

@openshift-ci-robot
Copy link

@dfajmon: This pull request references Jira Issue OCPBUGS-61222, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@dfajmon: This pull request references Jira Issue OCPBUGS-61222, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfajmon
Copy link
Author

dfajmon commented Sep 11, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 11, 2025
@openshift-ci-robot
Copy link

@dfajmon: This pull request references Jira Issue OCPBUGS-61222, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfajmon
Copy link
Author

dfajmon commented Sep 11, 2025

This was fixed in 1.35 kubernetes kubernetes#133186
I have opened a backport PR. At the moment the tests are blocking kubernetes rebase

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label backports/unvalidated-commits
/lgtm

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Sep 11, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
Copy link

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, dfajmon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2025
@radeore
Copy link

radeore commented Sep 11, 2025

/verified by ci/e2e-aws-ovn-techpreview

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 11, 2025
@openshift-ci-robot
Copy link

@radeore: This PR has been marked as verified by [ci/e2e-aws-ovn-techpreview](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_kubernetes/2452/pull-ci-openshift-kubernetes-master-e2e-aws-ovn-techpreview/1965692702183919616).

In response to this:

/verified by ci/e2e-aws-ovn-techpreview

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfajmon
Copy link
Author

dfajmon commented Sep 11, 2025

/test e2e-aws-ovn-hypershift

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fbd7a06 and 2 for PR HEAD 87b26c8 in total

@dfajmon
Copy link
Author

dfajmon commented Sep 12, 2025

/test e2e-aws-ovn-serial

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 679fad5 and 2 for PR HEAD 87b26c8 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 679fad5 and 2 for PR HEAD 87b26c8 in total

Copy link

openshift-ci bot commented Sep 13, 2025

@dfajmon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-techpreview-serial 87b26c8 link false /test e2e-aws-ovn-techpreview-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfajmon
Copy link
Author

dfajmon commented Sep 15, 2025

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit b59afbd into openshift:master Sep 15, 2025
24 of 25 checks passed
@openshift-ci-robot
Copy link

@dfajmon: Jira Issue Verification Checks: Jira Issue OCPBUGS-61222
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-61222 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

In response to this:

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Fix an issue in the test where a PersistentVolume (PV) was marked for deletion, but the test subsequently set its status back to Available, preventing the PV from being deleted.

Does this PR introduce a user-facing change?

None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.21.0-0.nightly-2025-10-02-215712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants