Bug 1872784: Bumping Buildah #170

otaviof · 2020-08-24T10:10:49Z

Using buildah version 1.15.2, given #169 is merged, we can use newest buildah.

openshift-ci-robot · 2020-08-24T10:10:53Z

@otaviof: This pull request references Bugzilla bug 1858779, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1858779: Bumping Buildah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

otaviof · 2020-08-24T10:17:52Z

@adambkaplan, I might be late to open this PR to bump buildah, so please let me know. (/cc @gabemontero, @coreydaley, @nalind)

otaviof · 2020-08-24T11:24:46Z

/bugzilla refresh

openshift-ci-robot · 2020-08-24T11:24:49Z

@otaviof: This pull request references Bugzilla bug 1858779, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nalind · 2020-08-24T14:13:45Z

LGTM

rhatdan · 2020-08-24T14:47:45Z

LGTM
/approve

otaviof · 2020-08-24T17:44:06Z

/assign @smarterclayton

adambkaplan · 2020-08-25T01:49:28Z

/unassign @smarterclayton

/assign @adambkaplan

adambkaplan · 2020-08-25T19:27:58Z

@otaviof we need a new BZ ID if we want to merge this in 4.6. the prior BZ was related to the CVE patch in golang/x/text.

IMO it is worthwhile to add one, as each OpenShift release should incorporate the latest buildah bugfixes and enhancements.

openshift-ci-robot · 2020-08-26T15:46:06Z

@otaviof: This pull request references Bugzilla bug 1872784, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1872784: Bumping Buildah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

otaviof · 2020-08-26T15:46:10Z

/bugzilla refresh

openshift-ci-robot · 2020-08-26T15:46:12Z

@otaviof: This pull request references Bugzilla bug 1872784, which is invalid:

expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coreydaley · 2020-08-26T16:17:55Z

/bugzilla refresh

openshift-ci-robot · 2020-08-26T16:18:34Z

@coreydaley: This pull request references Bugzilla bug 1872784, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

coreydaley · 2020-08-26T16:18:58Z

/lgtm

adambkaplan

/lgtm

openshift-ci-robot · 2020-09-04T08:11:32Z

@otaviof: This pull request references Bugzilla bug 1858779, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1858779: Bumping Buildah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-09-04T09:30:54Z

@otaviof: This pull request references Bugzilla bug 1858779, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1858779: Bumping Buildah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

otaviof · 2020-09-04T09:31:24Z

We just tagged [email protected], which includes the fix we would have regressed on if we'd used v1.15.1. @otaviof if you want to pull that in, I think we'll be okay. Thanks!

Sure. Thanks for the heads up. Please consider latest changes.

otaviof · 2020-09-04T12:58:45Z

/test e2e-aws-builds

openshift-ci-robot · 2020-09-04T15:01:27Z

@otaviof: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-builds	`882dc41`	link	`/test e2e-aws-builds`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

adambkaplan · 2020-09-04T21:05:43Z

@jupierce this is failing for the same reason that #171 is failing. The root cause is related to https://bugzilla.redhat.com/show_bug.cgi?id=1875639, which I filed last night.

I haven't seen a comment from RHEL engineering yet on this issue. @yselkowitz believes we are blocked because setting HTTP_PROXY and HTTPS_PROXY is breaking git.

openshift-ci-robot · 2020-09-08T05:10:53Z

@wewang58: This pull request references Bugzilla bug 1858779, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla cc-qa
Add this, just test "DevExp verified bugs before PR merge" workflow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wewang58 · 2020-09-08T05:15:21Z

/bugzilla cc-qa
Add the label, just try to test "Bug Fix PR Pre-Merge confirmation testing" workflow

openshift-ci-robot · 2020-09-08T05:15:23Z

@wewang58: This pull request references Bugzilla bug 1858779, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla cc-qa
Add the label, just try to test "Bug Fix PR Pre-Merge confirmation testing" workflow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wewang58 · 2020-09-08T05:15:58Z

/bugzilla refresh

openshift-ci-robot · 2020-09-08T05:16:01Z

@wewang58: This pull request references Bugzilla bug 1858779, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is VERIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wewang58 · 2020-09-08T05:19:00Z

/retitle Bug 1872784: Bumping Buildah

openshift-ci-robot · 2020-09-08T05:19:20Z

@otaviof: This pull request references Bugzilla bug 1872784, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872784: Bumping Buildah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wewang58 · 2020-09-08T05:22:22Z

/bugzilla cc-qa

openshift-ci-robot · 2020-09-08T05:22:25Z

@wewang58: This pull request references Bugzilla bug 1872784, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wewang58

In response to this:

/bugzilla cc-qa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

nalind · 2020-09-08T14:18:41Z

LGTM

openshift-ci-robot · 2020-09-09T13:49:48Z

@otaviof: This pull request references Bugzilla bug 1872784. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Bug 1872784: Bumping Buildah

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Aug 24, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 24, 2020

openshift-ci-robot requested review from coreydaley and gabemontero August 24, 2020 10:11

openshift-ci-robot assigned smarterclayton Aug 24, 2020

openshift-ci-robot assigned adambkaplan and unassigned smarterclayton Aug 25, 2020

otaviof changed the title ~~Bug 1858779: Bumping Buildah~~ Bug 1872784: Bumping Buildah Aug 26, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. and removed bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. labels Aug 26, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 26, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 26, 2020

openshift-ci-robot assigned coreydaley Aug 26, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2020

adambkaplan approved these changes Aug 27, 2020

View reviewed changes

openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 4, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 4, 2020

otaviof added 2 commits September 4, 2020 11:25

refactor(builder): using newer containers/common

c5be3bd

bump(buildah): to v1.15.2 and tidying up modules

882dc41

otaviof force-pushed the bug-1858779 branch from fe2ba83 to 882dc41 Compare September 4, 2020 09:30

openshift-ci-robot changed the title ~~Bug 1858779: Bumping Buildah~~ Bug 1872784: Bumping Buildah Sep 8, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 8, 2020

openshift-ci-robot requested a review from wewang58 September 8, 2020 05:22

otaviof closed this Sep 9, 2020

Bug 1872784: Bumping Buildah #170

Bug 1872784: Bumping Buildah #170

Uh oh!

Conversation

otaviof commented Aug 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 24, 2020

Uh oh!

otaviof commented Aug 24, 2020

Uh oh!

otaviof commented Aug 24, 2020

Uh oh!

openshift-ci-robot commented Aug 24, 2020

Uh oh!

nalind commented Aug 24, 2020

Uh oh!

rhatdan commented Aug 24, 2020

Uh oh!

otaviof commented Aug 24, 2020

Uh oh!

adambkaplan commented Aug 25, 2020

Uh oh!

adambkaplan commented Aug 25, 2020

Uh oh!

openshift-ci-robot commented Aug 26, 2020

Uh oh!

otaviof commented Aug 26, 2020

Uh oh!

openshift-ci-robot commented Aug 26, 2020

Uh oh!

coreydaley commented Aug 26, 2020

Uh oh!

openshift-ci-robot commented Aug 26, 2020

Uh oh!

coreydaley commented Aug 26, 2020

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Sep 4, 2020

Uh oh!

openshift-ci-robot commented Sep 4, 2020

Uh oh!

otaviof commented Sep 4, 2020

Uh oh!

otaviof commented Sep 4, 2020

Uh oh!

openshift-ci-robot commented Sep 4, 2020

Uh oh!

adambkaplan commented Sep 4, 2020

Uh oh!

openshift-ci-robot commented Sep 8, 2020

Uh oh!

wewang58 commented Sep 8, 2020

Uh oh!

openshift-ci-robot commented Sep 8, 2020

Uh oh!

wewang58 commented Sep 8, 2020

Uh oh!

openshift-ci-robot commented Sep 8, 2020

Uh oh!

wewang58 commented Sep 8, 2020

Uh oh!

openshift-ci-robot commented Sep 8, 2020

Uh oh!

wewang58 commented Sep 8, 2020

Uh oh!

openshift-ci-robot commented Sep 8, 2020

Uh oh!

nalind commented Sep 8, 2020

Uh oh!

openshift-ci-robot commented Sep 9, 2020

Uh oh!

Uh oh!

otaviof commented Aug 24, 2020 •

edited

Loading