Skip to content

Conversation

openshift-bot
Copy link
Contributor

This PR is autogenerated by the ocp-build-data-enforcer.
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the ocp-build-data repository used
for producing release artifacts.

If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.

This PR is autogenerated by the [ocp-build-data-enforcer][1].
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the [ocp-build-data repository][2] used
for producing release artifacts.

If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.

[1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer
[2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
@jupierce jupierce changed the title Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config Bug 1872080: Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: An error was encountered adding this pull request to the external tracker bugs for bug 1872080 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for a GitHub REST call. URL: https://github.com/api/repos/openshift/builder/pulls/171 Error: 403 Forbidden at /loader/0x559662b9a370/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x559662b9a370/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x559662b9a370/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559672...', 'https://github.com/api/repos/openshift/builder/pulls/171', 'GET') called at /loader/0x559662b9a370/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559672...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559672f33178)') called at /loader/0x559662b9a370/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x559662b9a370/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x559672f33178)', 1) called at /loader/0x559662b9a370/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x559672ead790)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 877 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x559672e86950)', 'HASH(0x5596722b7850)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x5596722b7850)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5596727813c0)') called at /loader/0x559662b9a370/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559672310260)') called at (eval 2593) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559672c2ff10)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559672c2ff10)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x559672388670)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x5596735d2b58)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x5596735d2b58)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559672388670)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x559672388670)') called at (eval 2593) line 0 eval {...} called at (eval 2593) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1872080: Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crawford
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

@crawford: This pull request references Bugzilla bug 1872080, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot openshift-bot changed the title Bug 1872080: Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config Aug 25, 2020
@openshift-ci-robot openshift-ci-robot removed the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 25, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 25, 2020
@openshift-bot openshift-bot changed the title Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config Bug 1872080: Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config Aug 26, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: This pull request references Bugzilla bug 1872080, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 26, 2020
@jupierce
Copy link
Contributor

/retest

@gabemontero
Copy link
Contributor

So this e2e-aws-builds test case failure may be related to this change @jupierce @crawford @adambkaplan

If you look at the test case https://github.com/openshift/origin/blob/master/test/extended/builds/start.go#L155-L156

And the consider the build output (click the open stdout link at https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_builder/171/pull-ci-openshift-builder-master-e2e-aws-builds/1298751110562975744 for one of the 2 failed instances)

You'll see Creating a new S2I builder

But instead of openshift-builder v (where v was assumed to be part of the version indicator from this log level 5 item https://github.com/openshift/builder/blob/master/pkg/build/builder/cmd/builder.go#L445 ... where that in turn is looking at the git commit info via https://github.com/openshift/builder/blob/master/pkg/version/version.go) I am seeing openshift-builder 1.14.4-0b36666

is it possible the format of the git commit / version text changed with the Dockerfile change here @jupierce ? I suspect so.

I do see the BUILLD_LOGLEVEL=5 env var set, and the build log does look verbose.

Might have a chicken / egg situation here. Disable this check in the test so this PR could merge. Then renable/change the check in the test to look for the new string a la openshift-builder 1.14.4-0b36666

@yselkowitz
Copy link
Contributor

@jupierce ^^^ is openshift-eng/ocp-build-data@b1b4239 needed in the rhel-7 golang-1.14 builder too?

@jupierce
Copy link
Contributor

jupierce commented Sep 1, 2020

/retest

@gabemontero
Copy link
Contributor

same error as before @jupierce @yselkowitz with https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_builder/171/pull-ci-openshift-builder-master-e2e-aws-builds/1300816099788460032

the version print does not meet the previously expected pattern of openshift-builder v 👍
I0901 16:27:43.048209 1 builder.go:383] openshift-builder 1.14.0-8-b1b4239

was something changed in the golang builder per #171 (comment) ?

@jupierce
Copy link
Contributor

jupierce commented Sep 1, 2020

@gabemontero thanks for the superb write-up! The earlier /retest was just automation to help some other PRs along. I'm working on your root cause now and should have a new golang image out shortly which I believe will fix this.

@gabemontero
Copy link
Contributor

@gabemontero thanks for the superb write-up! The earlier /retest was just automation to help some other PRs along. I'm working on your root cause now and should have a new golang image out shortly which I believe will fix this.

sounds good thanks @jupierce !

@jupierce
Copy link
Contributor

jupierce commented Sep 2, 2020

/retest

1 similar comment
@jupierce
Copy link
Contributor

jupierce commented Sep 2, 2020

/retest

@adambkaplan
Copy link
Contributor

For further reference, here is the script that sets the version info in make build: https://github.com/openshift/builder/blob/master/hack/lib/build/version.sh.

Not clear where the 1.14 info is coming from - that isn't a tag in the openshift/builder repo.

@jupierce
Copy link
Contributor

jupierce commented Sep 2, 2020

The latest run show I0902 04:39:44.943284 1 builder.go:383] openshift-builder v4.0.0+86af0f5-183-dirty . Are we on to new errors?

@crawford
Copy link

crawford commented Sep 3, 2020

I want to see how this fails again. I've seen other PRs fail with a similar set of errors.

/retest

@adambkaplan
Copy link
Contributor

Proxy tests are failing with a klog panic - need to investigate why.

@adambkaplan
Copy link
Contributor

@jupierce has #173 replaced this?

@crawford
Copy link

@adambkaplan we just closed #173. Thanks for the reminder.

/retest

@crawford
Copy link

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2020
@crawford crawford added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: crawford, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ee39800 into openshift:master Sep 10, 2020
@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

In response to this:

Bug 1872080: Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@yselkowitz: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yselkowitz
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@yselkowitz: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants