-
Notifications
You must be signed in to change notification settings - Fork 60
Bug 1872080: Updating Dockerfile.rhel8 baseimages to mach ocp-build-data config #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR is autogenerated by the [ocp-build-data-enforcer][1]. It updates the baseimages in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository][2] used for producing release artifacts. If you believe the content of this PR is incorrect, please contact the dptp team in #forum-testplatform. [1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer [2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images
@openshift-bot: An error was encountered adding this pull request to the external tracker bugs for bug 1872080 on the Bugzilla server at https://bugzilla.redhat.com:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@crawford: This pull request references Bugzilla bug 1872080, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-bot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-bot: This pull request references Bugzilla bug 1872080, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
So this e2e-aws-builds test case failure may be related to this change @jupierce @crawford @adambkaplan If you look at the test case https://github.com/openshift/origin/blob/master/test/extended/builds/start.go#L155-L156 And the consider the build output (click the You'll see But instead of is it possible the format of the git commit / version text changed with the Dockerfile change here @jupierce ? I suspect so. I do see the BUILLD_LOGLEVEL=5 env var set, and the build log does look verbose. Might have a chicken / egg situation here. Disable this check in the test so this PR could merge. Then renable/change the check in the test to look for the new string a la |
@jupierce ^^^ is openshift-eng/ocp-build-data@b1b4239 needed in the rhel-7 golang-1.14 builder too? |
/retest |
same error as before @jupierce @yselkowitz with https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_builder/171/pull-ci-openshift-builder-master-e2e-aws-builds/1300816099788460032 the version print does not meet the previously expected pattern of was something changed in the golang builder per #171 (comment) ? |
@gabemontero thanks for the superb write-up! The earlier |
sounds good thanks @jupierce ! |
/retest |
1 similar comment
/retest |
For further reference, here is the script that sets the version info in Not clear where the 1.14 info is coming from - that isn't a tag in the openshift/builder repo. |
The latest run show |
I want to see how this fails again. I've seen other PRs fail with a similar set of errors. /retest |
Proxy tests are failing with a |
@adambkaplan we just closed #173. Thanks for the reminder. /retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: crawford, openshift-bot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
/bugzilla refresh |
This PR is autogenerated by the ocp-build-data-enforcer.
It updates the baseimages in the Dockerfile used for promotion in order to ensure it
matches the configuration in the ocp-build-data repository used
for producing release artifacts.
If you believe the content of this PR is incorrect, please contact the dptp team in
#forum-testplatform.