-
Notifications
You must be signed in to change notification settings - Fork 47
Rebase to v1.3.0 #435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase to v1.3.0 #435
Conversation
…etadata Update metadata file
[e2e] Increase the vCPU quota limit for EC2 instances
Updated subnets field in Machinepool yaml
Bumps [github.com/aws/aws-lambda-go](https://github.com/aws/aws-lambda-go) from 1.27.0 to 1.27.1. - [Release notes](https://github.com/aws/aws-lambda-go/releases) - [Commits](aws/aws-lambda-go@v1.27.0...v1.27.1) --- updated-dependencies: - dependency-name: github.com/aws/aws-lambda-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/go-logr/logr](https://github.com/go-logr/logr) from 1.2.1 to 1.2.2. - [Release notes](https://github.com/go-logr/logr/releases) - [Changelog](https://github.com/go-logr/logr/blob/master/CHANGELOG.md) - [Commits](go-logr/logr@v1.2.1...v1.2.2) --- updated-dependencies: - dependency-name: github.com/go-logr/logr dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…tion-sg EKS: disable bastion sg when bastion is disabled
…ot/go_modules/github.com/aws/aws-lambda-go-1.27.1 build(deps): bump github.com/aws/aws-lambda-go from 1.27.0 to 1.27.1
…ot/go_modules/github.com/go-logr/logr-1.2.2 build(deps): bump github.com/go-logr/logr from 1.2.1 to 1.2.2
…-tests Refactor template_test.go to enable an individual run for each test case
EKS API conversion tests were silently exiting with panic due to an incorrect webhook config path. After enabling tests, fixed failing conversion tests in v1alpha3 and v1alpha4.
Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.2.1 to 1.3.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Changelog](https://github.com/spf13/cobra/blob/master/CHANGELOG.md) - [Commits](spf13/cobra@v1.2.1...v1.3.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Make EKS conversion tests run and fix failing conversion tests
It's not possible to add tags to the IAM bootstrap Cloudformation Stack without exporting it as a template and manually applying or editing the created stack. This commit adds the `stackTags` field to the [`AWSIAMConfigurationSpec`][0]. [0]: https://pkg.go.dev/sigs.k8s.io/cluster-api-provider-aws/cmd/clusterawsadm/api/bootstrap/v1beta1#AWSIAMConfigurationSpec
…ot/go_modules/github.com/spf13/cobra-1.3.0 build(deps): bump github.com/spf13/cobra from 1.2.1 to 1.3.0
Allow defining Cloudformation Stack tags
The `AWSManagedControlPlane` object conversion from `v1alpha3` to `v1beta1` were not considering new fields in status and spec. The bug is covered by tests, but these are failing silently at the moment as described in kubernetes-sigs#3032.
…sion_fix Fix AWSManagedControlPlane conversion
As described in [go#34129], `os.Exit()` in the way we have in multiple tests in this project make panics to fail silently. That was first described in kubernetes-sigs#3032. Since go 1.15 the `os.Exit(code)` calls are not required, therefore, let's make panics visible and just run `m.Run()`. [go#34129]: golang/go#34129
…exit Remove os.Exit calls from TestMain
Bumps [github.com/itchyny/gojq](https://github.com/itchyny/gojq) from 0.12.5 to 0.12.6. - [Release notes](https://github.com/itchyny/gojq/releases) - [Changelog](https://github.com/itchyny/gojq/blob/main/CHANGELOG.md) - [Commits](itchyny/gojq@v0.12.5...v0.12.6) --- updated-dependencies: - dependency-name: github.com/itchyny/gojq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Fix e2e ECR creation/lookup
Add unit tests for package pkg/cloud/tags
Bump to CAPI v1.1.0
Signed-off-by: Mateusz Gozdek <[email protected]>
…tting Applied automatically using gofumpt. Signed-off-by: Mateusz Gozdek <[email protected]>
…ixes test/e2e: fix typo and some formatting
Some resources had only delete log while other resources create/delete logs were missing.
Add lint-fix to Makefile target
Deleted unused files from sts package
Make logging for creating/deleting AWS resources consistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the commit structure looks generally good to me
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
@alexander-demichev: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
This commit rebases the cluster-api-provider-aws openshift patches on top of the kubernetes-sigs/cluster-api-provider-aws main branch after.
There are several commits that we carry on top of the upstream cluster-api-provider-azure and the rebase process allows us to preserve those. Here is a description of the process I used to create this PR.
(replicated @elmiko's process within openshift/kubernetes-autoscaler)
Process
First we need to identify the carry commits that we currently have, this is done against our previous rebase (or fork in this case) to catch new changes. Once identified we will drop commits which have merged upstream and only carry unique commits. (see below for the carried and dropped commits).
Identify carry commits:
After identifying the carry commits, the next step is to create the new commit-tree that will be used for the rebase and then cherry pick the carry commits into the new branch. The following commands cover these steps:
With the rebase-upstream-latest branch in place, I cherry picked the carry commits which we should carry.
Carried Commits
These commits are integral to our CI platform, or are specific to the releases we create for OpenShift.
Changed Commits