Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data

[elmiko]

What this PR does / why we need it:

This change adds a new Dockerfile.rhel file to control builds that
target rhel. It is inspired by the automatically generated patches which
ensure that build files match what is in the
ocp-build-data
repository
used for producing release artifacts.

After this change merges, the configuration files in
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/cluster-api-provider-openstack/openshift-cluster-api-provider-openstack-master.yaml
and
https://github.com/openshift/ocp-build-data/blob/openshift-4.6/images/ose-openstack-machine-controllers.yml
should be updated with the new dockerfile path.

Which issue(s) this PR fixes
Bugzilla 1872080

[openshift-ci-robot]

@elmiko: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@elmiko: This pull request references Bugzilla bug 1872080, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@elmiko: This pull request references Bugzilla bug 1872080, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.6.0) matches configured target release for branch (4.6.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

this patch is intended to replace #113 , the reason i am proposing a new dockerfile is to help enable our community(OKD) users to continue to build these components while not disrupting the rhel-based builds needed for our releases.

after this has merged and we have updated the related configurations, we could examine deprecating the .rhel7 file when it is no longer needed.

[elmiko]

/test e2e-openstack

[mandre]

/approve
/retest

[mandre]

Hi @elmiko, thanks for the patch. This is indeed a better solution if it allows OKD to continue building the images. Will you take care of updating the configs in the release and ocp-build-data repos to point to the new Dockerfile once the patch merges or should we?

[elmiko]

hi @mandre , i will create a patch to update the ocp-build-data and the release repo once this patch lands. to make things simple i am going to coordinate with the other PRs i've placed on the machine-api provider components. so it might take a few days depending on when things merge.

my goal is to have all this merged during our current sprint (within the next 2 weeks).

[elmiko]

/retest

[iamemilio]

We are having issues with our test infra right now

[crawford]

/retest

[crawford]

/retest

[enxebre]

/retest
/lgtm

[openshift-ci-robot]

@enxebre: changing LGTM is restricted to collaborators

In response to this:

/retest
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

for some reason Alberto's lgtm didn't get picked up, re-adding

/lgtm

[openshift-ci-robot]

@elmiko: you cannot LGTM your own PR.

In response to this:

for some reason Alberto's lgtm didn't get picked up, re-adding

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

adding a reference to the dependent PR, openshift-eng/ocp-build-data#636

[pierreprinetti]

/retest

[pierreprinetti]

/lgtm
/hold until CI succeeds

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, enxebre, mandre, michaelgugino, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mandre,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elmiko]

/test e2e-openstack

[elmiko]

/test e2e-openstack

[crawford]

OpenStack CI is in the process of switching between infrastructure providers, so CI might not be giving us a great signal. Looking at the most recent failure, I see etcd having trouble forming quorum due to load on the machine. I'm pretty comfortable moving forward with this anyway.

/override ci/prow/e2e-openstack
/hold cancel

[openshift-ci-robot]

@crawford: Overrode contexts on behalf of crawford: ci/prow/e2e-openstack

In response to this:

OpenStack CI is in the process of switching between infrastructure providers, so CI might not be giving us a great signal. Looking at the most recent failure, I see etcd having trouble forming quorum due to load on the machine. I'm pretty comfortable moving forward with this anyway.

/override ci/prow/e2e-openstack
/hold cancel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[elmiko]

thanks for the help Alex!

[openshift-ci-robot]

@elmiko: Some pull requests linked via external trackers have merged:

• operator-framework/operator-registry#426
• operator-framework/operator-marketplace#331
• operator-framework/operator-lifecycle-manager#1738
• openshift/whereabouts-cni#28
• openshift/vertical-pod-autoscaler-operator#33
• openshift/thanos#34
• openshift/telemeter#350
• openshift/sriov-network-operator#334
• openshift/sriov-network-operator#333
• openshift/sriov-network-operator#332
• openshift/sriov-network-device-plugin#29
• openshift/sriov-dp-admission-controller#20
• openshift/sriov-cni#19
• openshift/sig-storage-local-static-provisioner#24
• openshift/service-ca-operator#120
• openshift/sdn#177
• openshift/sdn#176

The following pull requests linked via external trackers have not merged:

• openshift/router#173 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

In response to this:

Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.