Bug 1872080: Add images/cluster-autoscaler/Dockerfile.rhel to match build configuration in ocp-build-data #168

elmiko · 2020-08-25T20:29:36Z

This change adds a new Dockerfile.rhel file to control building release
images. It updates the baseimages in the Dockerfile used for promotion
in order to ensure it matches the configuration in the
ocp-build-data repository
used for producing release artifacts.

After this change merges, the release files in
https://github.com/openshift/release/blob/master/ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-master.yaml
and
https://github.com/openshift/ocp-build-data/blob/openshift-4.6/images/atomic-openshift-cluster-autoscaler.yml
should be updated with the new dockerfile path.

openshift-ci-robot · 2020-08-25T20:29:41Z

@elmiko: This pull request references Bugzilla bug 1872080, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…e.rhel to match build configuration in ocp-build-data This change adds a new Dockerfile.rhel file to control building release images. It updates the baseimages in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository](https://github.com/openshift/ocp-build-data/tree/openshift-4.6-rhel-8/images) used for producing release artifacts. After this change merges, the release files in https://github.com/openshift/release/blob/master/ci-operator/config/openshift/kubernetes-autoscaler/openshift-kubernetes-autoscaler-master.yaml should be updated with the new dockerfile path.

michaelgugino · 2020-08-25T20:33:47Z

/lgtm

elmiko · 2020-08-25T20:35:49Z

/bugzilla refresh

openshift-ci-robot · 2020-08-25T20:35:52Z

@elmiko: This pull request references Bugzilla bug 1872080, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elmiko · 2020-08-25T20:37:20Z

this is a fix to replace #166

openshift-ci-robot · 2020-08-26T13:57:26Z

@elmiko: This pull request references Bugzilla bug 1872080, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1872080: Add images/cluster-autoscaler/Dockerfile.rhel to match build configuration in ocp-build-data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

elmiko · 2020-08-26T13:57:48Z

/retest

yselkowitz · 2020-08-26T23:40:57Z

/retest

crawford · 2020-09-01T17:06:29Z

/retest

enxebre · 2020-09-01T17:39:26Z

Shouldn't this PR get rid of the Dockerfile.rhel7? or if it's currently referenced by CI at least symlink to this new file?

elmiko · 2020-09-01T17:46:54Z

Shouldn't this PR get rid of the Dockerfile.rhel7? or if it's currently referenced by CI at least symlink to this new file?

i responded in another repo, but i wanted to keep the rhel7 files in place until we could get all the ci configs figured out, at which point i would like to remove them.

enxebre · 2020-09-02T08:54:56Z

Thanks @elmiko

i responded in another repo, but i wanted to keep the rhel7 files in place until we could get all the ci configs figured out, at which point i would like to remove them.

Yeh so I was suggesting to make it a symlink so this changes are immediately visible and consumed, otherwise this is just an unused dockerfile at the minute we are merging. Don't have any signal it even builds.

Referencing counter part PR openshift-eng/ocp-build-data#636.
Is there another PR for the CI release repo? can you please reference it in the desc?

Let's move forward and make sure we follow up to remove unnecessary dockerfiles afterwards.
/approve

openshift-ci-robot · 2020-09-02T08:55:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-02T09:02:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-02T10:00:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-02T10:13:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-02T10:30:25Z

@elmiko: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-azure-operator	`ac76690`	link	`/test e2e-azure-operator`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-09-02T11:05:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-02T12:04:53Z

@elmiko: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/router#173 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1872080 has not been moved to the MODIFIED state.

In response to this:

Bug 1872080: Add images/cluster-autoscaler/Dockerfile.rhel to match build configuration in ocp-build-data

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This change is in support of bugzilla 1872080. It modifies the configuration files for the machine-api components by adjusting their dockerfile to match the newly created "Dockerfile.rhel" files. This change also depends on several pull requests and should not be merged until they are: openshift/machine-api-operator#692 openshift/cluster-api-provider-gcp#118 openshift/cluster-api-provider-aws#349 openshift/cluster-api-provider-ovirt#67 openshift/cluster-api-provider-openstack#115 openshift/kubernetes-autoscaler#169 openshift/kubernetes-autoscaler#168 openshift/cluster-api-provider-azure#161 openshift/cluster-api-provider-baremetal#102 openshift/cluster-autoscaler-operator#161 openshift/cluster-machine-approver#83

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 25, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 25, 2020

openshift-ci-robot requested review from alexander-demicev and enxebre August 25, 2020 20:30

elmiko mentioned this pull request Aug 25, 2020

Bug 1872080: Updating images/cluster-autoscaler/Dockerfile.rhel7 baseimages to mach ocp-build-data config #166

Closed

elmiko changed the title ~~Bug 1872080: Add Dockerfile.rhel to match build configuration in ocp-build-data~~ Bug 1872080: Add images/cluster-autoscaler/Dockerfile.rhel to match build configuration in ocp-build-data Aug 25, 2020

elmiko force-pushed the ca-bz-1872080 branch from 777ddf6 to ac76690 Compare August 25, 2020 20:31

openshift-ci-robot assigned michaelgugino Aug 25, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2020

elmiko mentioned this pull request Sep 1, 2020

Update dockerfile paths for machine-api image configurations openshift-eng/ocp-build-data#636

Merged

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2020

openshift-merge-robot merged commit 7186e47 into openshift:master Sep 2, 2020

elmiko deleted the ca-bz-1872080 branch September 18, 2020 18:36

Bug 1872080: Add images/cluster-autoscaler/Dockerfile.rhel to match build configuration in ocp-build-data #168

Bug 1872080: Add images/cluster-autoscaler/Dockerfile.rhel to match build configuration in ocp-build-data #168

Uh oh!

Conversation

elmiko commented Aug 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Aug 25, 2020

Uh oh!

michaelgugino commented Aug 25, 2020

Uh oh!

elmiko commented Aug 25, 2020

Uh oh!

openshift-ci-robot commented Aug 25, 2020

Uh oh!

elmiko commented Aug 25, 2020

Uh oh!

openshift-ci-robot commented Aug 26, 2020

Uh oh!

elmiko commented Aug 26, 2020

Uh oh!

yselkowitz commented Aug 26, 2020

Uh oh!

crawford commented Sep 1, 2020

Uh oh!

enxebre commented Sep 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elmiko commented Sep 1, 2020

Uh oh!

enxebre commented Sep 2, 2020

Uh oh!

openshift-ci-robot commented Sep 2, 2020

Uh oh!

openshift-bot commented Sep 2, 2020

Uh oh!

openshift-bot commented Sep 2, 2020

Uh oh!

openshift-bot commented Sep 2, 2020

Uh oh!

openshift-ci-robot commented Sep 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Sep 2, 2020

Uh oh!

openshift-ci-robot commented Sep 2, 2020

Uh oh!

Uh oh!

elmiko commented Aug 25, 2020 •

edited

Loading

enxebre commented Sep 1, 2020 •

edited

Loading

openshift-ci-robot commented Sep 2, 2020 •

edited

Loading