Skip to content

Conversation

cloud-team-rebase-bot[bot]
Copy link

No description provided.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 12, 2025
Copy link

openshift-ci bot commented May 12, 2025

Hi @cloud-team-rebase-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from elmiko and frobware May 12, 2025 18:54
YanzhaoLi and others added 3 commits June 16, 2025 19:37
…-groups

Add created node group to considered node groups during scale-up
Update deployment.yaml to add volumeattachments permission
@elmiko
Copy link

elmiko commented Jun 18, 2025

unlikely this will work, but might as well try

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 18, 2025
k8s-ci-robot and others added 10 commits June 24, 2025 03:22
…t-success

OCI provider: Avoid interpreting HTTP 404 as success on delete
…-cloud-endpoint-reloving

fix bug 8168 GetEndpoint resolving fail
…e-terminate-by-default

feat: cordon node before terminate by default
this change adds debug logs at level 5 to aid in triaging failed node
balancing. It adds logs to help determine why two node groups are not
considered as similar. These logs can be quite noisy so the logging
level has been set to 5 by default.
AEP-7862: Decouple Startup CPU Boost from VPA modes - updates
* add h4d pricing

* fix go fmt

* revert gofmt on other files
cluster-autoscaler: add logging for failed node balancing
…r-ca

Add capacity buffers scalable objects, limits and fake pods injection
@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/kubernetes/autoscaler:cluster-autoscaler-1.33.0 (1959f5f) into main Merge https://github.com/kubernetes/autoscaler:cluster-autoscaler-1.33.1 (c95a8d9) into main Sep 25, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 25, 2025
Copy link

openshift-ci bot commented Sep 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maxcao13 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cloud-team-rebase-bot cloud-team-rebase-bot bot changed the title Merge https://github.com/kubernetes/autoscaler:cluster-autoscaler-1.33.1 (c95a8d9) into main Merge https://github.com/kubernetes/autoscaler:cluster-autoscaler-1.34.0 (dd28ada) into main Sep 29, 2025
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 29, 2025
cloud-team-rebase-bot and others added 13 commits October 2, 2025 13:43
This change carries files and modifications that are used by OpenShift
release infrastructure and related files.

* spec file
* dockerfiles
  * vertical-pod-autoscaler/Dockerfile.rhel
  * vertical-pod-autoscaler/Dockerfile.openshift
  * images/cluster-autoscaler/Dockerfile
  * images/cluster-autoscaler/Dockerfile.rhel
* hack scripts (ci and build related)
* Makefile
* JUnit tools
* update gitignore
* update/remove OWNERS files
* ci-operator config yaml
* remove gitignore file from vertical-pod-autoscaler (allow vendor
  addition)
* add Snyk file to exclude vendor directories and problematic cloud
  providers on scan

# Conflicts:
#	OWNERS_ALIASES
#	cluster-autoscaler/OWNERS
#	vertical-pod-autoscaler/OWNERS
Add vendor folders
  * cluster-autoscaler
  * balancer
  * vertical-pod-autoscaler
  * vertical-pod-autoscaler/e2e
…otation

The delete annotation upstream has a different format, but is now
inferred dynamically from the API group. If we update this in MAO to use
the new format, we can drop this old key
This change re-adds the machine api support for labels and taints on
node groups. The code was removed upstream as it is openshift specific,
see this pull request[0].

It also adds in the functionality of the upstream override annotation
for labels and taints[1] to support
https://issues.redhat.com/browse/MIXEDARCH-259

[0]: kubernetes#5249
[1]: kubernetes#5382
the upstream annotations for the scale from zero capacity resources is
slighty different than the openshift implementation. the largest
difference is the addition of a gpu type annotation. openshift does not
yet utilize this annotation and thus this patch should be carried until
the machineset controllers for the various providers on openshift have
been modified to use the new annotations.

another important change is the modification of the memory annotation.
previously in openshift we expected this value to be a count of memory
in Mebibytes. the conversion function and tests have been modified to
allow continued openshift operation.

this change can be dropped when the annotations in openshift have been
updated, the progress for this effort can be followed at
https://issues.redhat.com/browse/OCPCLOUD-944
…ider

This change corrects the behavior for parsing taints from the
unstructured scalable resource. This is required on OpenShift as our
implementation is slightly different from the upstream.
Also:
* Add unit tests for upstream annotations
* Update unit tests using upstream annotations new values
This OWNERS file is no longer autogenerated by Cluster Infrastructure owner-gen tooling.
Copy link

openshift-ci bot commented Oct 2, 2025

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • sig-autoscaling-vpa-reviewers
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.
  • sig-autoscaling-leads
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

Copy link

openshift-ci bot commented Oct 2, 2025

@cloud-team-rebase-bot[bot]: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 1b9cc5f link true /test security
ci/prow/unit 1b9cc5f link true /test unit
ci/prow/e2e-aws-operator 1b9cc5f link true /test e2e-aws-operator
ci/prow/images 1b9cc5f link true /test images
ci/prow/e2e-azure-operator 1b9cc5f link false /test e2e-azure-operator
ci/prow/goimports 1b9cc5f link false /test goimports
ci/prow/e2e-aws 1b9cc5f link true /test e2e-aws
ci/prow/okd-scos-e2e-aws-ovn 1b9cc5f link false /test okd-scos-e2e-aws-ovn
ci/prow/govet 1b9cc5f link true /test govet
ci/prow/git-history 1b9cc5f link false /test git-history
ci/prow/e2e-aws-periodic-pre 1b9cc5f link false /test e2e-aws-periodic-pre
ci/prow/e2e-hypershift 1b9cc5f link true /test e2e-hypershift
ci/prow/okd-scos-images 1b9cc5f link true /test okd-scos-images
ci/prow/e2e-gcp-operator 1b9cc5f link false /test e2e-gcp-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.