libvirt-template: Expand ARTIFACT_DIR env var to gcp instance run-tests script #11303
Conversation
sallyom
force-pushed
the
libvirt-e2e-template-fix
branch
from
ecf48dd to
dc387e1
Compare
sallyom
changed the title
|
@sallyom: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest |
|
/approved |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, sallyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sallyom: Updated the following 4 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| set -euo pipefail | ||
| export PATH=/home/packer:$PATH | ||
| mkdir -p ${ARTIFACT_DIR}/junit | ||
| mkdir -p /tmp/artifacts/junit |
There was a problem hiding this comment.
I would prefer you fix this by adding ARTIFACT_DIR to the env, so that we remained consistent across jobs.
There was a problem hiding this comment.
This is the follow-up: #11313
6 participants
This PR is broken due to ARTIFACT_DIR not being passed to gcp instance where the test script is run.
libvirt ci is broken due to this: openshift/release@83e9a57
I tried a few different ways of passing the var w/ quotes, etc. Every time I try it takes a long time to test and is still broken so let's simply expand the variable and unbreak this setup while we work to move the jobs to step-registry. It has to be expanded w/in the
cat > "${HOME}"/run-tests.sh << 'EOF'to be scp'd to the gcp instance where the install happens as '/tmp/artifacts' not ARTIFACT_DIR from the container env - I'm sure it's totally possible but let's unbreak and then focus on moving to step-registry.