Skip to content

libvirt-template: Expand ARTIFACT_DIR env var to gcp instance run-tests script #11303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2020
Merged

libvirt-template: Expand ARTIFACT_DIR env var to gcp instance run-tests script #11303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci-operator/templates/openshift/installer/cluster-launch-installer-libvirt-e2e.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,11 +205,11 @@ objects:
#!/bin/bash
set -euo pipefail
export PATH=/home/packer:$PATH
mkdir -p ${ARTIFACT_DIR}/junit
mkdir -p /tmp/artifacts/junit
Copy link
Contributor

@smarterclayton smarterclayton Aug 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer you fix this by adding ARTIFACT_DIR to the env, so that we remained consistent across jobs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the follow-up: #11313


function run-tests() {
openshift-tests run "${TEST_SUITE}" \
-o ${ARTIFACT_DIR}/e2e.log --junit-dir ${ARTIFACT_DIR}/junit
-o /tmp/artifacts/e2e.log --junit-dir /tmp/artifacts/junit
return 0
}

Expand Down