Skip to content

fix(core): Fixes merge fail in bulk logic #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 6, 2025
Merged

fix(core): Fixes merge fail in bulk logic #1966

merged 2 commits into from
Mar 6, 2025

Conversation

dmihalcik-virtru
Copy link
Member

Proposed Changes

  • Fixes some code in bulk rewrap that wasn't properly assigning the errors - or returning the correct error code - to the 'response' objects.
  • This most notably was causing failures with mixed EC and RSA wrapping requests, and for some 400s to be 500s.

Checklist

  • I have added or updated unit tests
  • I have added or updated integration tests (if appropriate)
  • I have added or updated documentation

Testing Instructions

@dmihalcik-virtru dmihalcik-virtru requested review from a team as code owners March 6, 2025 12:20
mkleene
mkleene approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@mkleene mkleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK and it seems safer, if anything. Is it important to guarantee this behavior with a test or does that seem like overkill?

@dmihalcik-virtru dmihalcik-virtru force-pushed the feature/fix-bulk-errors branch from 20174af to 885b5e2 Compare March 6, 2025 19:25
@dmihalcik-virtru
Copy link
Member Author

I'll look into refactoring it to be more testable and see if can put together it in a quick followup

@dmihalcik-virtru dmihalcik-virtru added this pull request to the merge queue Mar 6, 2025
Merged via the queue into main with commit c93bf62 Mar 6, 2025
22 checks passed
@dmihalcik-virtru dmihalcik-virtru deleted the feature/fix-bulk-errors branch March 6, 2025 19:47
@opentdf-automation opentdf-automation bot mentioned this pull request Mar 6, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 11, 2025
@opentdf-automation
chore(main): release service 0.4.40 (#1963)
141193e 
🤖 I have created a release *beep* *boop*
---


##
[0.4.40](service/v0.4.39...service/v0.4.40)
(2025-03-10)


### Bug Fixes

* **core:** Autobump service
([#1970](#1970))
([c0bbb11](c0bbb11))
* **core:** Autobump service
([#1976](#1976))
([c79fe0d](c79fe0d))
* **core:** Fixes merge fail in bulk logic
([#1966](#1966))
([c93bf62](c93bf62))
* **policy:** remove new public keys rpc's
([#1962](#1962))
([5049bab](5049bab))
* Service utilize `httputil.SafeHttpClient`
([#1926](#1926))
([af32700](af32700))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkleene mkleene mkleene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmihalcik-virtru @mkleene