feat(sdk): Expose connectrpc wrapper codegen for re-use

[elizabethhealy]

Proposed Changes

• move the connect rpc wrapper code gen out of internal so it can be re-used in sdk extension

Checklist

• I have added or updated unit tests
• I have added or updated integration tests (if appropriate)
• I have added or updated documentation

Testing Instructions

[gemini-code-assist]

Hello @elizabethhealy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

As gemini-code-assist, I've reviewed this pull request. The primary goal of this PR is to refactor the ConnectRPC wrapper code generation tool within the SDK. Previously located in an internal directory, the tool and its logic are being moved to a more accessible location (sdk/codegen) to facilitate reusability, particularly for SDK extensions. This involves restructuring the code generation entry point and making the core generation function more flexible by passing configuration parameters to it.

Highlights

• Enhanced Reusability: The core generation logic in sdk/codegen/runner/generate.go has been refactored to accept the list of clients and the output directory as arguments, making it reusable for external SDK extensions.
• Updated Build and Documentation: The Makefile targets (proto-generate, connect-wrapper-generate) and the sdk/codegen/README.md documentation have been updated to reflect the new location and usage of the codegen tool.

Changelog

Click here to see the changelog

• Makefile
  • Updated go run commands in proto-generate and connect-wrapper-generate targets to point to the new ./sdk/codegen path.
• sdk/codegen/README.md
  • Renamed the title from 'SDK Internal Codegen' to 'SDK Codegen'.
  • Updated the overview description to reflect the focus on ConnectRPC components.
  • Corrected the reference to the clientsToGenerateList variable location from runner/generate.go to main.go.
  • Updated the example command for running code generation to use the new ./sdk/codegen path.
• sdk/codegen/main.go
  • New file added.
  • Contains the main function which serves as the entry point for the codegen tool.
  • Defines the clientsToGenerateList variable specifying which gRPC interfaces to generate ConnectRPC wrappers for.
  • Determines the output directory (sdkconnect) and calls the refactored runner.Generate function.
• sdk/codegen/runner/generate.go
  • Removed the hardcoded clientsToGenerateList variable.
  • Refactored the Generate function to accept clientsToGenerateList and outputDir as parameters.
  • Renamed the clientsToGenerate struct to ClientsToGenerate and exported its fields.
  • Updated internal references to use the exported field names (e.g., client.GrpcClientInterface).
  • Removed the getCurrentFileDir helper function as the output directory is now passed in.
  • Updated the output path calculation to use the provided outputDir.
• sdk/internal/codegen/main.go
  • Deleted the old main entry point file for the internal codegen tool.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Code moves, path is new,
Reusable now for all,
Build scripts updated.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the ConnectRPC wrapper codegen logic by moving it from an internal package to a new sdk/codegen package. This change successfully achieves the goal of making the codegen reusable for SDK extensions. The restructuring is clean, and the necessary path and visibility adjustments have been made correctly.

Overall, the changes are well-executed and improve the codebase structure. I have one minor suggestion for an error message to enhance clarity.

Summary of Findings

• Incorrect Error Message Context: In sdk/codegen/main.go, the getCurrentFileDir function contains an error message that incorrectly refers to generate.go instead of main.go. This could cause minor confusion during debugging.

Merge Readiness

The pull request is well-structured and achieves its goal of making the codegen reusable. There is one medium-severity issue regarding an error message that should be addressed for clarity. Once that's updated, the PR should be in good shape for merging. As a reviewer, I am not authorized to approve pull requests, so please ensure other necessary reviews and approvals are obtained before merging.

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	467.19591ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	288.709792ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	348.327058ms
Throughput	287.09 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	53.606081031s
Average Latency	533.832558ms
Throughput	93.27 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4963
Failed Requests	37
Concurrent Requests	50
Total Time	44.656236497s
Average Latency	442.84225ms
Throughput	111.14 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	37 occurrences

Standard Benchmark Metrics Skipped or Failed

[github-actions]

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	484.146921ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	280.282929ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	343.855717ms
Throughput	290.82 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	56.114483668s
Average Latency	557.877048ms
Throughput	89.10 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4948
Failed Requests	52
Concurrent Requests	50
Total Time	44.531492766s
Average Latency	440.061501ms
Throughput	111.11 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	52 occurrences

Standard Benchmark Metrics Skipped or Failed