Skip to content

✨ Add .tiltignore #1655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025
Merged

✨ Add .tiltignore #1655

merged 1 commit into from
Jan 28, 2025

Conversation

trgeiger
Copy link
Contributor

.tiltignore specifies files for Tilt to ignore when it does automatic rebuilds. Ignoring these common text files prevents unnecessary rebuilds.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

.tiltignore specifies files for Tilt to ignore when it does automatic
rebuilds. Ignoring these common text files prevents unnecessary rebuilds.

Signed-off-by: Tayler Geiger <[email protected]>
@trgeiger trgeiger requested a review from a team as a code owner January 27, 2025 22:39
Copy link

netlify bot commented Jan 27, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit e895c2f
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/67980b2aecbac5000869aed8
😎 Deploy Preview https://deploy-preview-1655--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.40%. Comparing base (a46ff7d) to head (e895c2f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1655      +/-   ##
==========================================
- Coverage   67.42%   67.40%   -0.03%     
==========================================
  Files          55       55              
  Lines        4632     4632              
==========================================
- Hits         3123     3122       -1     
- Misses       1284     1285       +1     
  Partials      225      225              
Flag Coverage Δ
e2e 53.21% <ø> (ø)
unit 54.42% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@azych azych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably also ignore changes to test files and shell scripts:
*_test.go
*.sh

/lgtm

Copy link

openshift-ci bot commented Jan 28, 2025

@azych: changing LGTM is restricted to collaborators

In response to this:

We could probably also ignore changes to test files and shell scripts:
*_test.go
*.sh

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@perdasilva perdasilva added this pull request to the merge queue Jan 28, 2025
Merged via the queue into operator-framework:main with commit 570c2e5 Jan 28, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants