Skip to content

✨ Add test files and shell scripts to .tiltignore #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

azych
Copy link
Contributor

@azych azych commented Jan 28, 2025

Adds a few additional ignore entries for testfiles/directories and shell scripts to .tiltignore following #1655 and #1655 (review)

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@azych azych requested a review from a team as a code owner January 28, 2025 10:25
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 64e8349
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6798f01af7e7700008fed072
😎 Deploy Preview https://deploy-preview-1657--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@azych azych force-pushed the additional-tilt-ignores branch from 94357a0 to 2f8b9bb Compare January 28, 2025 10:27
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.40%. Comparing base (e667390) to head (64e8349).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1657      +/-   ##
==========================================
- Coverage   67.42%   67.40%   -0.03%     
==========================================
  Files          55       55              
  Lines        4632     4632              
==========================================
- Hits         3123     3122       -1     
- Misses       1284     1285       +1     
  Partials      225      225              
Flag Coverage Δ
e2e 53.21% <ø> (-0.09%) ⬇️
unit 54.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azych azych force-pushed the additional-tilt-ignores branch from 2f8b9bb to 64e8349 Compare January 28, 2025 14:56
@perdasilva perdasilva added this pull request to the merge queue Jan 28, 2025
Merged via the queue into operator-framework:main with commit 158d974 Jan 28, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants