🐛 fix crdupgradesafety diff when items schema differ #1863
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1863 +/- ##
==========================================
+ Coverage 68.45% 69.04% +0.59%
==========================================
Files 63 65 +2
Lines 5136 5263 +127
==========================================
+ Hits 3516 3634 +118
- Misses 1390 1396 +6
- Partials 230 233 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Joe Lanford <[email protected]>
Signed-off-by: Joe Lanford <[email protected]>
joelanford
force-pushed
the
fix-crdupgradesafety-diff
branch
from
2b142e1 to
2f57dbd
Compare
|
/lgtm |
|
Really appreciate the multi-commit approach here. It made it much easier to tease out which were adoption versus lint versus fix. Thanks! |
grokspawn
approved these changes
Mar 12, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1860
I also ended up deciding to copy the remaining bits from kapp into our repo so that we have control over our own destiny. Happy to discuss if folks have a differing opinion on that! The PR is structured into multiple commits to make it easy to see what I'm doing.
The first four commits are just pulling the copied code in, and getting it integrated into our repo.
The last commit is the actual fix itself.
Reviewer Checklist