🐛 Ensure fixed order in multi-line errors returned by crdupgradesafety validators #1864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
azych
force-pushed
the
ordered-errors-crdupgradesafety
branch
from
93fb65b to
a82e95b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1864 +/- ##
==========================================
- Coverage 69.04% 68.92% -0.13%
==========================================
Files 65 66 +1
Lines 5263 5236 -27
==========================================
- Hits 3634 3609 -25
+ Misses 1396 1395 -1
+ Partials 233 232 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Because of #1863, we can now introduce proper fix for the issue of randomly ordered errors causing `ClusterExtension' status changes and unnecessary reconciliations (see original issue here: #1456) without having to wait until the upstream fix is accepted in kapp (carvel-dev/kapp#1047).
Apart from the introducing proper fix and removal of temporary solution, this also refactors
ServedVersionValidatorout ofchecks.goand adds unit tests for it.Closes #1456
Reviewer Checklist