🌱 fix(ci): sanitize env for asciinema upload

[camilamacedo86]

Description

Fix the issue:

Run make demo-update
./hack/demo/generate-asciidemo.sh -u -n catalogd-demo catalogd-demo-script.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:01 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:02 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:03 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:04 --:--:--     0
  0     0    0     0    0     0      0      0 --:--:--  0:00:05 --:--:--     0
100  5481  100  5481    0     0    997      0  0:00:05  0:00:05 --:--:--  1277
asciinema: recording asciicast to /tmp/generate-asciidemo.f1eh[6](https://github.com/operator-framework/operator-controller/actions/runs/14495113504/job/40670980647?pr=1924#step:5:7)/catalogd-demo.cast
asciinema: exit opened program when you're done
asciinema: recording finished
asciinema: asciicast saved to /tmp/generate-asciidemo.f1eh6/catalogd-demo.cast
asciinema: upload failed: Invalid asciicast: {"errors":{"env":["must include only string values"]}}
make: *** [Makefile:421: demo-update] Error 1
Error: Process completed with exit code 2.

Example: https://github.com/operator-framework/operator-controller/actions/runs/14495113504/job/40670980647?pr=1924

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	3df2b97
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/68009d3765623c000870908c
😎 Deploy Preview	https://deploy-preview-1925--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.01%. Comparing base (543f099) to head (3df2b97).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1925      +/-   ##
==========================================
- Coverage   66.06%   66.01%   -0.05%     
==========================================
  Files          70       70              
  Lines        6182     6182              
==========================================
- Hits         4084     4081       -3     
- Misses       1839     1841       +2     
- Partials      259      260       +1     

Flag	Coverage Δ
e2e	45.09% <ø> (-0.07%)	⬇️
unit	55.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tmshort]

On an unrelated note, is there a reason why we are regenerating this ascii demo as a pre-submit job, which could easily break things? Why not a post-submit job?

[camilamacedo86]

Hi @tmshort

(Yes, I know env -i starts with an empty environment. Do you know what's in the existing CI's environment that's causing a problem?)

The fix keeps only the required ENV VARs, so future GitHub changes won’t break anything. For example, I couldn’t reproduce the issue locally (macOS) with the current code.

I didn’t dive deep into the exact ENV differences**—Because today it’s ENV A, tomorrow ENV B.** The goal was just to unblock us and avoid this from happening again. If we want to rethink the approach, we can always do that in a future PR. Personally, I don’t think it’s worth spending more time here on this one.

Let me know if anything seems off!

[tmshort]

It works locally for me on linux... but the question is, why is the CI environment "off"?

[tmshort]

I would at least like us to consider that this should be a post-submit job, and that it shouldn't block PRs... (not that it does right now)

[tmshort]

/lgtm
(To at least avoid the red ❌ )

[tmshort]

This has not fixed the Ci... :(