Skip to content

🌱 fix(ci): sanitize env for asciinema upload #1925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

🌱 fix(ci): sanitize env for asciinema upload #1925

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .github/workflows/catalogd-demo.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,11 @@ jobs:
with:
go-version-file: "go.mod"
- name: Run Demo Update
run: make demo-update
run: |
env -i \
HOME="$HOME" \
PATH="$PATH" \
TERM="xterm-256color" \
SHELL="/bin/bash" \
make demo-update
Copy link
Contributor Author

@camilamacedo86 camilamacedo86 Apr 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tmshort

(Yes, I know env -i starts with an empty environment. Do you know what's in the existing CI's environment that's causing a problem?)

The fix keeps only the required ENV VARs, so future GitHub changes won’t break anything. For example, I couldn’t reproduce the issue locally (macOS) with the current code.

I didn’t dive deep into the exact ENV differences**—Because today it’s ENV A, tomorrow ENV B.** The goal was just to unblock us and avoid this from happening again. If we want to rethink the approach, we can always do that in a future PR. Personally, I don’t think it’s worth spending more time here on this one.

Let me know if anything seems off!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works locally for me on linux... but the question is, why is the CI environment "off"?