🐛 fix: don't template registry+v1 manifests

[joelanford]

Description

Some registry+v1 manifests may actually contain Go Template strings that are meant to survive and actually persist into etcd (e.g. to be used as a templated configuration for another component). In order to avoid applying templating logic to registry+v1's static manifests, we create the manifests as Files, and then template those files via simple Templates.

Reviewer Checklist

• API Go Documentation
• Tests: Unit Tests (and E2E Tests, if appropriate)
• Comprehensive Commit Messages
• Links to related GitHub Issue(s)

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	9811d1b
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/682cf3ea4d22d00008895619
😎 Deploy Preview	https://deploy-preview-1979--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.14%. Comparing base (9a61b22) to head (9811d1b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
+ Coverage   69.10%   69.14%   +0.03%     
==========================================
  Files          79       79              
  Lines        7011     7023      +12     
==========================================
+ Hits         4845     4856      +11     
- Misses       1885     1886       +1     
  Partials      281      281              

Flag	Coverage Δ
e2e	41.61% <100.00%> (+0.13%)	⬆️
unit	59.97% <100.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[grokspawn]

I wouldn't worry about the upgrade-e2e CI, but it seems weird to me that we are only now seeing the sanity/lint errors, and those look easy enough to resolve.

[grokspawn]

/override upgrade-e2e

[openshift-ci]

@grokspawn: Overrode contexts on behalf of grokspawn: upgrade-e2e

In response to this:

/override upgrade-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [grokspawn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment