Skip to content

🐛 fix install and upgrade e2es #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joelanford
Copy link
Member

Follow-up on #1979:

  • make upgrade-e2e pass again
  • fix ClusterExtensionInstallReResolvesWhenCatalogIsPatched

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@joelanford joelanford requested a review from a team as a code owner May 20, 2025 22:14
Copy link

netlify bot commented May 20, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 1e15baa
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/682dd70a3592f9000809adae
😎 Deploy Preview https://deploy-preview-1983--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@openshift-ci openshift-ci bot requested review from gallettilance and OchiengEd May 20, 2025 22:14
@joelanford joelanford changed the title fix: install and upgrade e2es 🐛 fix: install and upgrade e2es May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.11%. Comparing base (f5dc9a9) to head (1e15baa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1983   +/-   ##
=======================================
  Coverage   69.11%   69.11%           
=======================================
  Files          79       79           
  Lines        7023     7023           
=======================================
  Hits         4854     4854           
  Misses       1887     1887           
  Partials      282      282           
Flag Coverage Δ
e2e 43.11% <ø> (+1.55%) ⬆️
unit 59.97% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joelanford joelanford changed the title 🐛 fix: install and upgrade e2es 🐛 fix install and upgrade e2es May 21, 2025
@tmshort
Copy link
Contributor

tmshort commented May 21, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2025
Copy link

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2025
@tmshort tmshort changed the title 🐛 fix install and upgrade e2es 🐛 fix install and upgrade e2es May 21, 2025
@tmshort
Copy link
Contributor

tmshort commented May 21, 2025

/retitle 🐛 fix install and upgrade e2es

- make upgrade-e2e pass again
- fix ClusterExtensionInstallReResolvesWhenCatalogIsPatched
@joelanford joelanford force-pushed the fix-registryv1-static-manifests-upgrade-e2e branch from 26c0682 to 1e15baa Compare May 21, 2025 13:37
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2025
@tmshort tmshort changed the title 🐛 fix install and upgrade e2es fix install and upgrade e2es May 21, 2025
@tmshort tmshort changed the title fix install and upgrade e2es 🐛 fix install and upgrade e2es May 21, 2025
@tmshort
Copy link
Contributor

tmshort commented May 21, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit cecd003 into operator-framework:main May 21, 2025
21 of 23 checks passed
@joelanford joelanford deleted the fix-registryv1-static-manifests-upgrade-e2e branch June 5, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants