Skip to content

✨ Update operator-registry to v1.55.0 #1981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

trgeiger
Copy link
Contributor

This adds Network Policy support.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@trgeiger trgeiger requested a review from a team as a code owner May 20, 2025 21:01
Copy link

netlify bot commented May 20, 2025

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 78404cd
🔍 Latest deploy log https://app.netlify.com/projects/olmv1/deploys/682de34163458300084889fe
😎 Deploy Preview https://deploy-preview-1981--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@tmshort
Copy link
Contributor

tmshort commented May 20, 2025

Looks as though a go mod tidy is needed.

Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.11%. Comparing base (cecd003) to head (78404cd).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1981   +/-   ##
=======================================
  Coverage   69.11%   69.11%           
=======================================
  Files          79       79           
  Lines        7023     7023           
=======================================
  Hits         4854     4854           
  Misses       1887     1887           
  Partials      282      282           
Flag Coverage Δ
e2e 43.11% <ø> (ø)
unit 59.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@trgeiger trgeiger force-pushed the update-op-registry branch from 705d470 to a7e9e59 Compare May 20, 2025 22:10
camilamacedo86
camilamacedo86 previously approved these changes May 20, 2025
Copy link
Contributor

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2025
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@camilamacedo86
Copy link
Contributor

Yep, it is not passing in the test: https://github.com/operator-framework/operator-controller/actions/runs/15148862481/job/42590962019?pr=1981

go mod tidy

/approve cancel
/lgtm cancel

Until pass on the tests

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 20, 2025
@camilamacedo86 camilamacedo86 dismissed their stale review May 20, 2025 23:21

Not passing on the tests.

@trgeiger
Copy link
Contributor Author

Those test results are after a go mod tidy so we will need to figure out what in the new dependency versions is causing the tests to fail.

@trgeiger
Copy link
Contributor Author

Can someone restart the upgrade-e2e? I just ran it locally and it passed fine, might just have been some timeout issue.

@grokspawn
Copy link
Contributor

You may need to rebase to pick up upgrade-e2e fixes in #1983 (not sure if CI runs against branch-latest or main).

This adds Network Policy support.
@trgeiger trgeiger force-pushed the update-op-registry branch from a7e9e59 to 78404cd Compare May 21, 2025 14:29
@grokspawn
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 21, 2025
@oceanc80
Copy link
Contributor

/lgtm
/approve

Copy link

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, oceanc80, rashmigottipati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 532c306 into operator-framework:main May 21, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants