Merge upstream #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not use `-u` flag when fetching go-acc
seperated -> separated
The busy_timeout pragma was added in sqlite 3.7.15 as an alternative to calling sqlite3_busy_timeout directly: https://sqlite.org/pragma.html#pragma_busy_timeout While there's no functional change here, using the pragma does align setting busy_timeout with other settings and removes the special case for calling sqlite3_busy_timeout directly.
uses snippet suggested by @rittneje #897 (comment)
* sqlite3_type update The main reason for this change is that the original reflected values are nil. I found that there was no good mapping when dealing with the code here * Update sqlite3_type.go Update 'ColumnTypeScanType' method, Different types of mapping values * Restore copyright * Update go.mod * Update go.mod
Selecting only some tests with go test -run=... does not work, because some of the tests are executed using testing.RunTests(). That function is documented as "an internal function". This changes TestSuite to use the testing subtests feature instead. This has a behaviour change: the benchmarks now need to be selected at the command line with the standard go test -bench=. flag. This will also set up the test database twice when running benchmarks, rather than once.
* Add go.mod and go.sum for upgrade * Fix upgrade tools to have to run on upgrade directory
Currently, no way to fix failing
This commit adds the SQLiteConn.FileControlInt() method which calls the underlying sqlite3_file_control() function with an int argument. This can be used for low-level operations on SQLite databases such as persisting the WAL file after database close.
Based on https://golang.org/pkg/database/sql/#Tx.Commit this function returns an error type. So why not check it.
Support returning any from callbacks
(For #965.) This retraction will take effect when this commit is included in the latest v1 release (presumably v1.14.11).
This commit adds the `sqlite_os_trace` build tag which sets the `SQLITE_FORCE_OS_TRACE` and `SQLITE_DEBUG_OS_TRACE` compilation flags. This produces verbose debugging output of every operating system call made by SQLite.
Fixes a test which did not correctly exercise the multi-statement Queryer functionality
R.I.P. godoc.org
Always rollback on a commit error
Fix typo in README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.