-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
REF: Move to_dict
implementation to pandas.core.methods.to_dict
#49845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
i dont think the |
Fair point - other than a new file inside of core, I don't see a good location for something like this. Also, is there opposition to moving the implementation of |
ive been thinking a core/methods/ directory might be good for files that are basically just individual refactored-out methods (e.g. describe.py) |
+1 in @jbrockmendel idea |
to_dict
implementation to pandas.ioto_dict
implementation to pandas.core.methods.to_dict
Does this still need discussion, happy to have a stab at this if we want to go ahead with the refactor |
@kostyafarber - no more discussion is needed - have at it! |
Ref: #46487 (review)
For code organization, it'd be good to get the implementation of these methods out of
frame.py
and to a more suitable location -pandas.core.methods.to_dict
The text was updated successfully, but these errors were encountered: