-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
REF: refactor implementation of to_dict out of frame.py and into core.methods.to_dict #50253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rhshadrach friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @kostyafarber! There are other methods that should now go in this directory - describe is one example. Would you be interested in continuing this kind of refactor? |
Hey @rhshadrach no worries, glad I can help - Yeah sure! If you wanna open up an issue with a list of methods, I can open PRs against them and work on it. |
@rhshadrach shall I look into describe or are you compiling a list? Happy to work on describe in the meantime. |
@kostyafarber - I don't plan on compiling a list; I think describe would be great to work on. |
@rhshadrach |
? |
@kostyafarber - thanks for the ping; yes, that's correct. |
to_dict
implementation to pandas.core.methods.to_dict #49845 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.Following #46487 (review) a decision was made to move the implementation of
to_dict
inframe.py
intopandas.core.methods.to_dict
.