Skip to content

REF: refactor implementation of to_dict out of frame.py and into core.methods.to_dict #50253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 17, 2022

Conversation

kostyafarber
Copy link
Contributor

Following #46487 (review) a decision was made to move the implementation of to_dict in frame.py into pandas.core.methods.to_dict.

@kostyafarber kostyafarber changed the title REF: refactor to_dict out of frame.py and into core/methods/to_dict.py REF: refactor implementation of to_dict out of frame.py and into core.methods.to_dict Dec 14, 2022
@kostyafarber
Copy link
Contributor Author

@rhshadrach friendly ping

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Refactor Internal refactoring of code IO Data IO issues that don't fit into a more specific label labels Dec 16, 2022
@rhshadrach rhshadrach added this to the 2.0 milestone Dec 16, 2022
@rhshadrach rhshadrach merged commit 2f993c2 into pandas-dev:main Dec 17, 2022
@kostyafarber kostyafarber deleted the issue-49845 branch December 17, 2022 13:59
@rhshadrach
Copy link
Member

Thanks @kostyafarber! There are other methods that should now go in this directory - describe is one example. Would you be interested in continuing this kind of refactor?

@kostyafarber
Copy link
Contributor Author

Hey @rhshadrach no worries, glad I can help - Yeah sure!

If you wanna open up an issue with a list of methods, I can open PRs against them and work on it.

@kostyafarber
Copy link
Contributor Author

@rhshadrach shall I look into describe or are you compiling a list? Happy to work on describe in the meantime.

@rhshadrach
Copy link
Member

@kostyafarber - I don't plan on compiling a list; I think describe would be great to work on.

@kostyafarber
Copy link
Contributor Author

@rhshadrach describe.py currently is as a standalone file in core would the refactor simply be moving that file into methods?

@kostyafarber
Copy link
Contributor Author

?

@rhshadrach
Copy link
Member

@kostyafarber - thanks for the ping; yes, that's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO Data IO issues that don't fit into a more specific label Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

REF: Move to_dict implementation to pandas.core.methods.to_dict
2 participants