-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
Rearrange _NaT to be valid python; add attributes tests #17756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @jbrockmendel! Thanks for updating the PR. Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated on October 03, 2017 at 15:27 Hours UTC |
Codecov Report
@@ Coverage Diff @@
## master #17756 +/- ##
==========================================
- Coverage 91.25% 91.23% -0.02%
==========================================
Files 163 163
Lines 49856 49856
==========================================
- Hits 45496 45487 -9
- Misses 4360 4369 +9
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #17756 +/- ##
==========================================
- Coverage 91.23% 91.21% -0.02%
==========================================
Files 163 163
Lines 49869 49869
==========================================
- Hits 45499 45490 -9
- Misses 4370 4379 +9
Continue to review full report at Codecov.
|
what exactly does this fix? there are no current build errros |
It's pre-emptive. Note the branch name has a "2". That's because build errors occurred in |
Supserseded by #17765, where the build errors are now fixed. |
At the moment the organization of
tslib
is not valid python: child classes are defined above parent classes. This PR fixes that for_NaT
andNaTType
.This is necessary because trying to implement more important changes in
NaTType
is leading to build errors:Hopefully fixing this will fix the build error.
This also implements tests for NaT namespace/docstrings.
git diff upstream/master -u -- "*.py" | flake8 --diff