Implement NaT properties/methods directly #17765
Conversation
| @@ -156,6 +158,44 @@ def test_NaT_methods(): | |||
| assert NaT.isoformat() == 'NaT' | |||
|
|
|||
|
|
|||
| def test_NaT_docstrings(): | |||
There was a problem hiding this comment.
add the issue number as a comment
| ts_expected = ['freqstr', 'normalize', 'offset', | ||
| 'to_julian_date', 'to_period', 'tz'] | ||
| assert ts_missing == ts_expected | ||
|
|
There was a problem hiding this comment.
give a comment before each 'section' of the test so a future reader gets what you are testing
|
Just added comments. Note that the test implemented here is identical (except for the new comments) to the one implemented in #17756 |
jreback
added
Missing-data
Codecov Report
@@ Coverage Diff @@
## master #17765 +/- ##
==========================================
+ Coverage 91.23% 91.24% +<.01%
==========================================
Files 163 163
Lines 49869 49872 +3
==========================================
+ Hits 45499 45505 +6
+ Misses 4370 4367 -3
Continue to review full report at Codecov.
|
| tzname = _make_error_func('tzname', datetime) | ||
| utcoffset = _make_error_func('utcoffset', datetime) | ||
|
|
||
| # Timestamp has empty docstring for some methods. |
There was a problem hiding this comment.
these are not defined directly in Timestamp/_Timestamp rather directly in datetime.datetime, maybe direct to there? (I don't know where its actually defined, nor why the inheritence messes this up)
There was a problem hiding this comment.
They are defined in Timestamp and have empty docstrings there. No idea why. Will add to todo list.
|
thanks! |
Causes build errors, referenced in #17756
git diff upstream/master -u -- "*.py" | flake8 --diff