Skip to content

CLN:F-string formatting #29554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Nov 12, 2019
Merged

CLN:F-string formatting #29554

merged 32 commits into from
Nov 12, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Nov 11, 2019

Ref to #29547

  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

@ShaharNaveh ShaharNaveh changed the title F string pyx CLN:F-string formatting Nov 11, 2019
@ShaharNaveh ShaharNaveh marked this pull request as ready for review November 12, 2019 08:46
@ShaharNaveh
Copy link
Member Author

ping @jbrockmendel

@jbrockmendel
Copy link
Member

trailing whitespace

@ShaharNaveh
Copy link
Member Author

gentle desperate ping @jbrockmendel

@jbrockmendel
Copy link
Member

LGTM cc @WillAyd

@jreback jreback added the Clean label Nov 12, 2019
@jreback jreback added this to the 1.0 milestone Nov 12, 2019
@jreback jreback merged commit 794a1c2 into pandas-dev:master Nov 12, 2019
@jreback
Copy link
Contributor

jreback commented Nov 12, 2019

thanks @MomIsBestFriend

definitely more readable with the f-strings, keep em coming!

ShaharNaveh pushed a commit to ShaharNaveh/pandas that referenced this pull request Nov 13, 2019
ShaharNaveh pushed a commit to ShaharNaveh/pandas that referenced this pull request Nov 13, 2019
ShaharNaveh pushed a commit to ShaharNaveh/pandas that referenced this pull request Nov 13, 2019
ShaharNaveh pushed a commit to ShaharNaveh/pandas that referenced this pull request Nov 13, 2019
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants