Skip to content

CLN: f-string at pandas/_libs/tslib.pyx #29593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2019

Conversation

ShaharNaveh
Copy link
Member

@ShaharNaveh ShaharNaveh commented Nov 13, 2019

Continuation of previous PR

  • tests passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff

ref to issue #29547

@ShaharNaveh ShaharNaveh marked this pull request as ready for review November 13, 2019 14:13
@jreback jreback added the Code Style Code style, linting, code_checks label Nov 13, 2019
@jreback jreback added this to the 1.0 milestone Nov 13, 2019
@ShaharNaveh ShaharNaveh requested a review from jreback November 13, 2019 21:18
@jreback jreback merged commit 65a4ee6 into pandas-dev:master Nov 14, 2019
@jreback
Copy link
Contributor

jreback commented Nov 14, 2019

thanks !

@ShaharNaveh ShaharNaveh deleted the CLN-f-string-in-tslib-pyx branch November 14, 2019 21:01
Reksbril pushed a commit to Reksbril/pandas that referenced this pull request Nov 18, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants