BUG/TST: Address GH28283 calling __finalize__ in pivot_table, groupby.median and groupby.mean #39473
Conversation
pandas/core/reshape/pivot.py
Outdated
| table = concat(pieces, keys=keys, axis=1) | ||
| return table.__finalize__(data, method="pivot_table") | ||
|
|
||
| table = _pivot_table( |
There was a problem hiding this comment.
this is way more complicated to read. need to simplify this or have a better name for _pivot_table -> __internal_pivot_table, and add a doc-string & types.
There was a problem hiding this comment.
this maybe worth reverting and doing in a dedicated PR.
There was a problem hiding this comment.
Just finished reading the requirements for doc-string. Will rename the function and add a doc-string & types.
where is this? |
|
@liaoaoyuan97 if you can fix up would be great. (and merge master) |
| ) -> DataFrame: | ||
| """ | ||
| Equivalent of :func:`pandas.pivot_table`, except only allowing non-list ``aggfunc``. | ||
| """ |
There was a problem hiding this comment.
@jreback I didn't use a sharing doctring since other methods sharing it need to change. Considering it is for internal use only, devs can find reference by knowing the relation btw internal and external ones.
Please let me know your thoughts.
|
@jreback I think all your comments are addressed. Would you ming taking a took? |
|
@rhshadrach if you'd have a look |
|
Thanks @liaoaoyuan97! |
Progress towards #28283
pivot_tablefunction to avoid overhead of_finalize__calls when a list of aggfuncs passed__finalize__before returninggroupby.meanandgroupby.mediangroupby.std/var/sem/size/ohlc/describeas a reminder to fix(they are failing currently)