-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
BUG/TST: Address GH28283 calling __finalize__ in pivot_table, groupby.median and groupby.mean #39473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rhshadrach
merged 18 commits into
pandas-dev:master
from
liaoaoyuan97:GH28283-pivot-table
Feb 20, 2021
Merged
BUG/TST: Address GH28283 calling __finalize__ in pivot_table, groupby.median and groupby.mean #39473
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
d9e2f64
TST:unxfail test for calling __finalize__ in DataFrame.pivot_table
liaoaoyuan97 aaa09b5
TST:add tests for calling __finalize__ in DataFrame.groupby.mean and …
liaoaoyuan97 820089c
TST:add xfail tests for calling __finalize__ in groupby operations
liaoaoyuan97 02a777c
BUG: propagate metadata via calling __finalize__ in groupby.mean and …
liaoaoyuan97 33fca3e
TST: add tests for calling __finalize__ in pivot_table with multiple …
liaoaoyuan97 5f23bef
BUG + PERF: call __finalize__ in pivot_table
liaoaoyuan97 8322385
DOC: update whatsnew
liaoaoyuan97 d022983
DOC: update whatsnew
liaoaoyuan97 e17c31f
TYP: add type hints for pandas.pivot_table
liaoaoyuan97 5ba2824
DOC: rename pivot_table for internal use and add docstring
liaoaoyuan97 e8b9e0b
TYP: add type hints for pandas.pivot_table
liaoaoyuan97 73a84b7
DOC: update whatsnew
liaoaoyuan97 f058996
Merge branch 'master' into GH28283-pivot-table
liaoaoyuan97 6a47ef3
Resolve merge conflicts in whatsnew
liaoaoyuan97 2ac796a
Resolve merge conflicts
liaoaoyuan97 b3a8a49
Resolve merge conflicts in pivot.py
liaoaoyuan97 d9d282a
update docstring
liaoaoyuan97 af43447
Merge branch 'master' of github.com:pandas-dev/pandas into GH28283-pi…
liaoaoyuan97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jreback I didn't use a sharing doctring since other methods sharing it need to change. Considering it is for internal use only, devs can find reference by knowing the relation btw internal and external ones.
Please let me know your thoughts.