Fix for #347 (include in LiveList) #348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First implementation
|
With f4860d2 the the network traffic get reduced. So this feature should be optimized now. I have done basic testing. (Note: Currently LiveList will not update, if an included object get updated. I will commit an option, that enables listening for updates on included objects.) |
|
Sorry, closed this by accident. |
|
Great work |
phillwiggins
added a commit
that referenced
this pull request
Aug 28, 2020
* Release 1.0.27 - Create base branch * Fix for #347 (include in LiveList) (#348) * LiveList: reload included objects First implementation * Key was wrong on order change * include sub-includes * reuse loaded pointers * Deleted stuff * LiveList autoupdate included sub-objects (#349) * LiveList: reload included objects First implementation * Key was wrong on order change * include sub-includes * reuse loaded pointers * Deleted stuff * Adding listening on included objects to LiveList * Updated readme for ParseLiveList * Update parse_live_list.dart * LiveList: sync subObjects after reconnect (#352) * Sync subObjects after reconnect * Update README.md * Update README.md (#353) * ISSUE-351: Replaced isTypeOfException with Exception (#355) Great work! Thank you * RegisterSubClass and smaler changes (#368) * added subclass handler * integraded subclass handler * added constructor for QueryBuilder using registered SubClasses * subclass handler optimizations * Convenience changes * Convenience change * sembast CoreStore on macos * Fix: ParseUser updated on server but not locally This should be a fix for: #364 and #256 * Update README.md * Update README.md * Update README.md (#367) * Save installationId when new installation created. Send installationId when User login (#375) * ParseLiveElement (#376) * First implementation for ParseLiveElement * ParseLiveElement further implementation * Update parse_live_list.dart * ParseLiveElement working * News methods for ParseQuery - whereMatchesKeyInQuery and whereDoesNotMatchKeyInQuery (#379) * Add method whereMatchesKeyInQuery Add method whereMatchesKeyInQuery * Update parse_query.dart * Fix whereMatchesKeyInQuery / whereDoesNotMatchKeyInQuery * Update README.md * Update README.md * Update README.md * Add google login helper (#387) - Update README to show how to get google login attributes for parse * Update parse_response_builder.dart (#390) * [web] Check web before Platform.isX (#392) Platform.isX is unsupported in web * Make web compatible calls for locale and skip PackageInfo (#395) * Make web compatible calls for locale and skip PackageInfo * Also get country code for web locale * Add description of early web support * Added ParseFile check to _canBeSerialized() (#396) * Update README.md (#397) Fix Parse Server parameter name * ParseLiveList: first implementation of lazyLoading (#407) Setting lazyLoading=false should disable lazyLoading. * Update parse_live_list.dart (#406) In theory this should not make any difference. In practise sometimes an error gets thrown: The following NoSuchMethodError was thrown while finalizing the widget tree: The method 'dispose' was called on null. Receiver: null Tried calling: dispose() * File Support for web (#409) * created files and started implementation * add different filetypes to sdk * Update README.md * add an other file example to README (#410) * added file example to README * Update README.md * Web file upload: set content type to "text/plain" incase neighter name nor url is set (#411) This breaks the extension at the uploaded file, but otherwise the upload would fail with a server error. * LiveQuery reconnecting intervals (#414) * parseFileConstructor was missing at Parse.initialize * add liveListRetryIntervals to Parse.initialize * replace kIsWeb with its definition (#415) Using less libaries is always good. * release/1.0.27 update dependencies * Release/1.0.27 (#427) * forgetLocalSession before login / signUP / loginAnonymous #426 * forgetLocalSession before login / signUP / loginAnonymous #426 * Release 1.0.27 - Pre-release process - Update dependencies * Release 1.0.27 - Pre-release process - Static analysis fixes Co-authored-by: Maximilian Fischer <[email protected]> Co-authored-by: Michal Baran <[email protected]> Co-authored-by: Maximilian Fischer <[email protected]> Co-authored-by: Phani Rithvij <[email protected]> Co-authored-by: Danaru <[email protected]> Co-authored-by: Rodrigo de Souza Marques <[email protected]> Co-authored-by: vreamer <[email protected]> Co-authored-by: Dmytro Karpovych <[email protected]> Co-authored-by: Nils Strelow <[email protected]> Co-authored-by: hyperrecursive <[email protected]>
fischerscode
added a commit
to fischerscode/Parse-SDK-Flutter
that referenced
this pull request
Sep 5, 2020
* LiveList: reload included objects First implementation * Key was wrong on order change * include sub-includes * reuse loaded pointers * Deleted stuff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #347.
It's not optimal jet as some network traffic is avoidable.
Listening for updates in included objects is jet not possible.
I might contribute this two changes soon, too.
(Note: a30de87 is not related to #347 but it fixes an bug, where an old widget state is displayed, when the order of an object changes, but not the position in the list. If it sounds confusing, just ignore this.)
EDIT:
See #348 (comment) for update.