Make web compatible calls for locale and skip PackageInfo #395
+17
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds to #392 to further improve web compatibility.
General web support issue: #385
Replaces following incompatible packages only for web:
Devicelocale.currentLocale (magnatronus/flutter-devicelocale#9)
Replaced by
ui.window.locale.languageCode
from dart:ui package.This outputs the language as ("en_US", "en_GB"), same as on Android with Devicelocale (Devicelocale returns - dashes for iOS).
PackageInfo (flutter/flutter#46609)
Here I opted to remove all the properties coming from PackageInfo.
Parsing the yaml file and injecting them inside the app somehow could work, but I would rather wait and hope for PackageInfo to support web sometime in the future.
Pending Readme changes.