-
-
Notifications
You must be signed in to change notification settings - Fork 206
New version 3.2.0 #738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New version 3.2.0 #738
Conversation
…ubspec.yaml Fix logout error when no user is logged in Update dependencies in pubspec.yaml
Sinc Repo Development
Fixes for version 3.2.0
Thanks for opening this pull request!
|
Amazing work @RodrigoSMarques! Is there a reason why you didn't open separate PRs for each of the issues? We are generally trying to avoid combined PRs, to keep discussions separated and make it easier to identify bugs that a PR may introduce. |
Not. There is no special reason. We didn't have this process before. This is the first patch package, after Phill passed the package to Parse. The fixes I made are in different COMMITs. The other bugs have already been merged previously. |
Got it. It's not a PR with many file changes, so maybe we can just merge it all together, what do you think @fischerscode? In the future that won't be possible anymore, as every commit will generate its own changelog entry, so any fix has to be handled separately in a distinct PR. |
packages/flutter/example/linux/flutter/ephemeral/.plugin_symlinks/connectivity_plus_linux
Outdated
Show resolved
Hide resolved
packages/flutter/example/macos/Flutter/ephemeral/Flutter-Generated.xcconfig
Outdated
Show resolved
Hide resolved
👍 I'd not do that in the future, but since this seem to be a collection of changes, I think it should be fine this time. |
when is the release? |
We first need to resolve the discussion in #668 |
Remove unnecessary files from the project
can you please publish |
@RodrigoSMarques Could you please bring this PR up-to-date with a rebase and add the changelog entries? Entries should only go to the package in which the changes occur. We do separate releases and versioning now. See #668 (comment). Usually it would 1 changelog entry per PR, but as discussed earlier, this PR will lead to multiple entries, so that's fine for now as we don't have any automation depending on it. Then we should be finally ready to make a release. |
@RodrigoSMarques Some of the issues you mention in the PR description have already been closed, could you please clarify why they are mentioned here? |
This week I have a busy schedule. I'll see what I can do. |
I do not remember. I believe I checked the issues that were open. As they were closed by you, I did not find. I will add to the changelog. |
ParseLiveListWidget is sending the wrong GET request if lazyloading is enabled and no order limiter is set. We have to check if there is a key to send
Updated Readme.md to include information about some extra steps to support for the desktop - macOS platform to connect to the Web and retrive/store information on Parse server due to the changes in the macOS framwork after macOS 10.7 so that user's using the Parse SDK Flutter can get their app running quick and without issues.
Fixes for version 3.2.0
Remove unnecessary files from the project
Thanks, I think you'd need to do a rebase, not just a merge; the CI here still shows Travis CI and is not running the new workflows.
To clarify, if they are already in the latest releases, they should not be added to the changelog of this new version, but retroactively to the changelog of the version where they have been merged into. |
@@ -116,3 +116,5 @@ app.*.symbols | |||
!**/ios/**/default.perspectivev3 | |||
!/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages | |||
!/dev/ci/**/Gemfile.lock | |||
/packages/flutter/example/linux/flutter/ephemeral/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should not be needed, we already have a gitignore entry for these files on master; should be fixed with a rebase
@@ -1,3 +1,15 @@ | |||
## 3.2.0 | |||
Bug fixes: | |||
* #717 - Old version of connectivity_plus package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the latest version of the file, flutter is already at version 3.1.2. I think you need to do a rebase (not just a branch merge) to fix these inconsistencies. And could you please take a look at the new changelog format.
So this will be merged into master? Right? |
Yes, I think this has been auto-closed when I deleted the development branch. I am not able to change the base branch of this PR to (There may be other PRs that have been auto-closed) |
The communication continues in #762 |
New Pull Request Checklist
Issue Description
Related issue: #717, #714, #712, #696, #679, #661, #653
Approach
TODOs before merging
3.2.0
Bug fixes:
* #717 - Old version of connectivity_plus package
* #714 - package_info_plus not work in web
* #712 - MissingPluginException (No implementation found for method getAll)
* #696 - ParseRelation#query - Unhandled Exception: type 'ParseObject' is not a subtype of type
* #679 - Error in progressCallback
* #661 - first: Correct return type
* #653 - ParseLiveListWidget MongoError
Updated dependencies versions
Documentation update