Skip to content

New version 3.2.0 #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RodrigoSMarques
Copy link
Contributor

@RodrigoSMarques RodrigoSMarques commented May 2, 2022

New Pull Request Checklist

Issue Description

* #717 - Old version of connectivity_plus package
* #714 - package_info_plus not work in web
* #712 - MissingPluginException (No implementation found for method getAll)
* #696 - ParseRelation#query - Unhandled Exception: type 'ParseObject' is not a subtype of type
* #679 - Error in progressCallback
* #661 - first: Correct return type
* #653 - ParseLiveListWidget MongoError

Related issue: #717, #714, #712, #696, #679, #661, #653

Approach

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)
  • A changelog entry

3.2.0

Bug fixes:
* #717 - Old version of connectivity_plus package
* #714 - package_info_plus not work in web
* #712 - MissingPluginException (No implementation found for method getAll)
* #696 - ParseRelation#query - Unhandled Exception: type 'ParseObject' is not a subtype of type
* #679 - Error in progressCallback
* #661 - first: Correct return type
* #653 - ParseLiveListWidget MongoError
Updated dependencies versions
Documentation update

@parse-github-assistant
Copy link

parse-github-assistant bot commented May 2, 2022

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@mtrezza
Copy link
Member

mtrezza commented May 2, 2022

Amazing work @RodrigoSMarques!

Is there a reason why you didn't open separate PRs for each of the issues? We are generally trying to avoid combined PRs, to keep discussions separated and make it easier to identify bugs that a PR may introduce.

@RodrigoSMarques
Copy link
Contributor Author

Amazing work @RodrigoSMarques!

Is there a reason why you didn't open separate PRs for each of the issues? We are generally trying to avoid combined PRs, to keep discussions separated and make it easier to identify bugs that a PR may introduce.

Not. There is no special reason. We didn't have this process before.

This is the first patch package, after Phill passed the package to Parse.

The fixes I made are in different COMMITs.

The other bugs have already been merged previously.

@mtrezza
Copy link
Member

mtrezza commented May 2, 2022

Got it. It's not a PR with many file changes, so maybe we can just merge it all together, what do you think @fischerscode?

In the future that won't be possible anymore, as every commit will generate its own changelog entry, so any fix has to be handled separately in a distinct PR.

@fischerscode
Copy link
Contributor

so maybe we can just merge it all together

👍 I'd not do that in the future, but since this seem to be a collection of changes, I think it should be fine this time.

@LavTeamProject
Copy link

when is the release?

@mtrezza
Copy link
Member

mtrezza commented May 9, 2022

We first need to resolve the discussion in #668

@serhatuysal
Copy link

can you please publish

@mtrezza
Copy link
Member

mtrezza commented May 29, 2022

@RodrigoSMarques Could you please bring this PR up-to-date with a rebase and add the changelog entries? Entries should only go to the package in which the changes occur. We do separate releases and versioning now. See #668 (comment). Usually it would 1 changelog entry per PR, but as discussed earlier, this PR will lead to multiple entries, so that's fine for now as we don't have any automation depending on it.

Then we should be finally ready to make a release.

@mtrezza
Copy link
Member

mtrezza commented May 30, 2022

@RodrigoSMarques Some of the issues you mention in the PR description have already been closed, could you please clarify why they are mentioned here?

@RodrigoSMarques
Copy link
Contributor Author

@RodrigoSMarques Could you please bring this PR up-to-date with a rebase and add the changelog entries? Entries should only go to the package in which the changes occur. We do separate releases and versioning now. See #668 (comment). Usually it would 1 changelog entry per PR, but as discussed earlier, this PR will lead to multiple entries, so that's fine for now as we don't have any automation depending on it.

Then we should be finally ready to make a release.

This week I have a busy schedule. I'll see what I can do.

@RodrigoSMarques
Copy link
Contributor Author

@RodrigoSMarques Some of the issues you mention in the PR description have already been closed, could you please clarify why they are mentioned here?

I do not remember. I believe I checked the issues that were open.

As they were closed by you, I did not find.

I will add to the changelog.

tk2232 and others added 14 commits May 31, 2022 12:54
ParseLiveListWidget is sending the wrong GET request if lazyloading is enabled and no order limiter is set.
We have to check if there is a key to send
Updated Readme.md to include information about some extra steps to support for the desktop - macOS platform to connect to the Web and retrive/store information on Parse server due to the changes in the macOS framwork after macOS 10.7 so that user's using the Parse SDK Flutter can get their app running quick and without issues.
Fixes for version 3.2.0
Remove unnecessary files from the project
@mtrezza
Copy link
Member

mtrezza commented May 31, 2022

Thanks, I think you'd need to do a rebase, not just a merge; the CI here still shows Travis CI and is not running the new workflows.

I will add to the changelog.

To clarify, if they are already in the latest releases, they should not be added to the changelog of this new version, but retroactively to the changelog of the version where they have been merged into.

@mtrezza mtrezza closed this May 31, 2022
@mtrezza mtrezza reopened this May 31, 2022
@@ -116,3 +116,5 @@ app.*.symbols
!**/ios/**/default.perspectivev3
!/packages/flutter_tools/test/data/dart_dependencies_test/**/.packages
!/dev/ci/**/Gemfile.lock
/packages/flutter/example/linux/flutter/ephemeral/
Copy link
Member

@mtrezza mtrezza May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should not be needed, we already have a gitignore entry for these files on master; should be fixed with a rebase

@@ -1,3 +1,15 @@
## 3.2.0
Bug fixes:
* #717 - Old version of connectivity_plus package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the latest version of the file, flutter is already at version 3.1.2. I think you need to do a rebase (not just a branch merge) to fix these inconsistencies. And could you please take a look at the new changelog format.

@mtrezza mtrezza deleted the branch parse-community:development June 1, 2022 15:44
@mtrezza mtrezza closed this Jun 1, 2022
@fischerscode
Copy link
Contributor

So this will be merged into master? Right?

@mtrezza
Copy link
Member

mtrezza commented Jun 2, 2022

Yes, I think this has been auto-closed when I deleted the development branch. I am not able to change the base branch of this PR to master, so @RodrigoSMarques could you please open a new PR? You may be able to change the base branch though and re-open the PR. Sorry for the additional work.

(There may be other PRs that have been auto-closed)

@fischerscode
Copy link
Contributor

The communication continues in #762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants