-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Parse Dashboard Hover Issue on Mobile Browsers #953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I think it’s a double click / tap issue. Single click selects a field Double click edits I guess we can change it to do single click edit for mobile. Feel free to open a PR. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Hi, any news on this feature? Its very important to be able to edit data on mobile browsers. Thanks! |
I think nobody has taken it yet. Would you be willed to help on this? |
Sure, but wouldn't know where to start :( |
I guess it is something that can be improved in this file here: https://github.com/parse-community/parse-dashboard/blob/master/src/components/BrowserCell/BrowserCell.react.js |
Yes! I think the answer is in the following lines in that file:
```
onClick={onSelect}
onDoubleClick={() => {
if (type !== 'Relation') {
onEditChange(true)
}
```
For mobile, onClick should return what onDoubleClick does. So we can edit with one click. Because on mobile with double click, browser caches it as increase page size.
The qiestion is how to know when mobile and when desktop.
Desktop should mantain current behavior.
What do you think?
|
Sorry couldnt format that last comment from my phone 🤷♂️ |
Or maybe better, on mobile, onLongClick should return the edition. With some timer for the long click it wouldnt be necesary to know if the browser is desktop or mobile I think |
It may be a good idea. Would you be able to test it and in case it works, send a PR? If you want to go with the web browser detection approach, here it goes a very good guide: https://developer.mozilla.org/en-US/docs/Web/HTTP/Browser_detection_using_the_user_agent |
I can't edit the values on mobile browsers.
I think it's a hover issue in the dashboard.bundle.js file.
The text was updated successfully, but these errors were encountered: