Skip to content

Parse Dashboard Hover Issue on Mobile Browsers #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
imnvs opened this issue Jan 13, 2019 · 10 comments · Fixed by #1222
Closed

Parse Dashboard Hover Issue on Mobile Browsers #953

imnvs opened this issue Jan 13, 2019 · 10 comments · Fixed by #1222
Labels
type:feature New feature or improvement of existing feature

Comments

@imnvs
Copy link

imnvs commented Jan 13, 2019

I can't edit the values on mobile browsers.
I think it's a hover issue in the dashboard.bundle.js file.

@dplewis
Copy link
Member

dplewis commented Jan 13, 2019

I think it’s a double click / tap issue.

Single click selects a field

Double click edits

I guess we can change it to do single click edit for mobile.

Feel free to open a PR.

@stale
Copy link

stale bot commented Mar 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the state:wont-fix Won’t be fixed with a clearly stated reason label Mar 2, 2019
@dplewis dplewis added enhancement and removed state:wont-fix Won’t be fixed with a clearly stated reason labels Mar 2, 2019
@ramiro-ciocca
Copy link

Hi, any news on this feature? Its very important to be able to edit data on mobile browsers. Thanks!

@davimacedo
Copy link
Member

I think nobody has taken it yet. Would you be willed to help on this?

@ramiro-ciocca
Copy link

Sure, but wouldn't know where to start :(

@davimacedo
Copy link
Member

I guess it is something that can be improved in this file here: https://github.com/parse-community/parse-dashboard/blob/master/src/components/BrowserCell/BrowserCell.react.js

@ramiro-ciocca
Copy link

ramiro-ciocca commented Aug 1, 2019 via email

@ramiro-ciocca
Copy link

Sorry couldnt format that last comment from my phone 🤷‍♂️

@ramiro-ciocca
Copy link

ramiro-ciocca commented Aug 1, 2019

Or maybe better, on mobile, onLongClick should return the edition. With some timer for the long click it wouldnt be necesary to know if the browser is desktop or mobile I think

@davimacedo
Copy link
Member

davimacedo commented Aug 1, 2019

It may be a good idea. Would you be able to test it and in case it works, send a PR? If you want to go with the web browser detection approach, here it goes a very good guide: https://developer.mozilla.org/en-US/docs/Web/HTTP/Browser_detection_using_the_user_agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New feature or improvement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants