-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(Database Browser): Editing values not possible on mobile #1222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Database Browser): Editing values not possible on mobile #1222
Conversation
So how does it work? In a mobile device, do I need to touch a first time to select the cell, then a second time to enable editing? It is not working for ACL. Can you please take a look? |
I just tried on iOS and it works great. I was also able to change boolean but since there isn't a tap outside event it could only be changed by selecting a different field. When I tried to upload a file I got |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for working on this long requested feature.
@davimacedo do you want to pull it down?
@dplewis did the ACL popup work for you? It was the only thing that didn't work properly for me, but I tested in Google Chrome. |
Nice. I've just tested again and it worked as well. I think in the first time I haven't noticed the popup was outside the screen I had to scroll in order to see it. This is probably something to be improved later. LGTM! |
I had the same issue when I first used it. That’s why I zoomed in on the recording. Could improve later |
Fixes #953