Skip to content

fix(Database Browser): Editing values not possible on mobile #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 15, 2019

Conversation

douglasmuraoka
Copy link
Contributor

Fixes #953

@davimacedo
Copy link
Member

So how does it work? In a mobile device, do I need to touch a first time to select the cell, then a second time to enable editing? It is not working for ACL. Can you please take a look?

@dplewis
Copy link
Member

dplewis commented Aug 15, 2019

I just tried on iOS and it works great.

I was also able to change boolean but since there isn't a tap outside event it could only be changed by selecting a different field.

When I tried to upload a file I got Unhandled Promise Rejection: Error: Tried to encode an unsaved file but the file was still uploaded when I refreshed. Its weird because I can upload a file as a default value. I'll look into it.

Copy link
Member

@dplewis dplewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this long requested feature.

@davimacedo do you want to pull it down?

@davimacedo
Copy link
Member

@dplewis did the ACL popup work for you? It was the only thing that didn't work properly for me, but I tested in Google Chrome.

@dplewis
Copy link
Member

dplewis commented Aug 15, 2019

It worked for me on Safari, Chrome and iOS.

Edit: sorry for the size

IMG_2559TRIM

@davimacedo
Copy link
Member

Nice. I've just tested again and it worked as well. I think in the first time I haven't noticed the popup was outside the screen I had to scroll in order to see it. This is probably something to be improved later. LGTM!

@davimacedo davimacedo merged commit b39be9c into parse-community:master Aug 15, 2019
@dplewis
Copy link
Member

dplewis commented Aug 15, 2019

I had the same issue when I first used it. That’s why I zoomed in on the recording.

Could improve later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Dashboard Hover Issue on Mobile Browsers
3 participants