Skip to content

feat: Persist info panel visibility when navigating across classes in data browser #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 16, 2025
Merged

feat: Persist info panel visibility when navigating across classes in data browser #2908

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17b1bc0
fix: persist AggregationPanel visibility across sessions
mtrezza Jul 16, 2025
16b480d
Update DataBrowser.react.js
mtrezza Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 29 additions & 10 deletions src/dashboard/Data/Browser/DataBrowser.react.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import styles from './Databrowser.scss';
import AggregationPanel from '../../../components/AggregationPanel/AggregationPanel';

const BROWSER_SHOW_ROW_NUMBER = 'browserShowRowNumber';
const AGGREGATION_PANEL_VISIBLE = 'aggregationPanelVisible';

function formatValueForCopy(value, type) {
if (value === undefined) {
Expand Down Expand Up @@ -79,6 +80,12 @@ export default class DataBrowser extends React.Component {
);
const storedRowNumber =
window.localStorage?.getItem(BROWSER_SHOW_ROW_NUMBER) === 'true';
const storedPanelVisible =
window.localStorage?.getItem(AGGREGATION_PANEL_VISIBLE) === 'true';
const hasAggregation =
props.classwiseCloudFunctions?.[
`${props.app.applicationId}${props.appName}`
]?.[props.className];

this.state = {
order: order,
Expand All @@ -88,7 +95,7 @@ export default class DataBrowser extends React.Component {
selectedObjectId: undefined,
simplifiedSchema: this.getSimplifiedSchema(props.schema, props.className),
allClassesSchema: this.getAllClassesSchema(props.schema, props.classes),
isPanelVisible: false,
isPanelVisible: storedPanelVisible && !!hasAggregation,
selectedCells: { list: new Set(), rowStart: -1, rowEnd: -1, colStart: -1, colEnd: -1 },
firstSelectedCell: null,
selectedData: [],
Expand Down Expand Up @@ -157,13 +164,17 @@ export default class DataBrowser extends React.Component {
this.setState({ order, frozenColumnIndex: -1 });
}
if (props && props.className) {
if (
!props.classwiseCloudFunctions?.[`${props.app.applicationId}${props.appName}`]?.[
props.className
]
) {
const storedPanelVisible =
window.localStorage?.getItem(AGGREGATION_PANEL_VISIBLE) === 'true';
const hasAggregation =
props.classwiseCloudFunctions?.[
`${props.app.applicationId}${props.appName}`
]?.[props.className];
if (!hasAggregation) {
this.setState({ isPanelVisible: false });
this.setState({ selectedObjectId: undefined });
} else {
this.setState({ isPanelVisible: storedPanelVisible });
}
} else {
this.setState({ isPanelVisible: false });
Expand Down Expand Up @@ -242,17 +253,19 @@ export default class DataBrowser extends React.Component {
}

togglePanelVisibility() {
this.setState(prevState => ({ isPanelVisible: !prevState.isPanelVisible }));
const newVisibility = !this.state.isPanelVisible;
this.setState({ isPanelVisible: newVisibility });
window.localStorage?.setItem(AGGREGATION_PANEL_VISIBLE, newVisibility);

if (!this.state.isPanelVisible) {
if (!newVisibility) {
this.props.setAggregationPanelData({});
this.props.setLoadingInfoPanel(false);
if (this.props.errorAggregatedData != {}) {
this.props.setErrorAggregatedData({});
}
}

if (!this.state.isPanelVisible && this.state.selectedObjectId) {
if (!newVisibility && this.state.selectedObjectId) {
if (this.props.errorAggregatedData != {}) {
this.props.setErrorAggregatedData({});
}
Expand Down Expand Up @@ -285,9 +298,15 @@ export default class DataBrowser extends React.Component {

checkClassNameChange(prevClassName, className) {
if (prevClassName !== className) {
const storedPanelVisible =
window.localStorage?.getItem(AGGREGATION_PANEL_VISIBLE) === 'true';
const hasAggregation =
this.props.classwiseCloudFunctions?.[
`${this.props.app.applicationId}${this.props.appName}`
]?.[className];
this.setState({
prevClassName: className,
isPanelVisible: false,
isPanelVisible: storedPanelVisible && !!hasAggregation,
selectedObjectId: undefined,
});
this.props.setAggregationPanelData({});
Expand Down
Loading