feat: Persist info panel visibility when navigating across classes in data browser

[mtrezza]

Summary

• keep AggregationPanel visibility across dashboard sessions

Testing

• npm test
• npm run lint

---

https://chatgpt.com/codex/tasks/task_e_6877844568d4832d8fe1c67008999e59

Summary by CodeRabbit

• New Features
  • The visibility state of the aggregation panel is now saved and restored between sessions, providing a more consistent user experience.
• Bug Fixes
  • Aggregation panel visibility is now correctly conditioned on the availability of aggregation functions for the selected class.
  • Hiding the aggregation panel now clears related data and error states for improved reliability.

[parse-github-assistant]

I will reformat the title to use the proper commit message syntax.

[parse-github-assistant]

🚀 Thanks for opening this pull request!

[coderabbitai]

📝 Walkthrough

"""

Walkthrough

The changes introduce persistent storage for the aggregation panel's visibility in the data browser component using localStorage. The component now initializes and updates its panel visibility state based on both the stored value and the presence of aggregation functions for the selected class, ensuring consistent behavior across sessions and class changes.

Changes

File(s)	Change Summary
src/dashboard/Data/Browser/DataBrowser.react.js	Added localStorage key for aggregation panel visibility; updated state initialization, lifecycle methods, and toggle logic to synchronize visibility state with localStorage and aggregation function availability; cleared aggregation data and triggered cloud function call when panel hidden.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant DataBrowser
    participant localStorage
    participant AggregationPanel
    participant CloudFunction

    User->>DataBrowser: Load or change class
    DataBrowser->>localStorage: Get aggregationPanelVisible
    DataBrowser->>DataBrowser: Check for aggregation functions
    DataBrowser->>DataBrowser: Set isPanelVisible (if aggregation exists and visible)
    User->>DataBrowser: Toggle panel visibility
    DataBrowser->>localStorage: Update aggregationPanelVisible
    DataBrowser->>AggregationPanel: Show/Hide panel
    alt Panel hidden
        DataBrowser->>AggregationPanel: Clear data and error states
        DataBrowser->>CloudFunction: Trigger call if object selected
    end

Loading

"""

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error code ERR_SSL_WRONG_VERSION_NUMBER
npm error errno ERR_SSL_WRONG_VERSION_NUMBER
npm error request to https://10.0.0.28:4873/npm/-/npm-10.9.3.tgz failed, reason: C0FC2B84FC7E0000:error:0A00010B:SSL routines:ssl3_get_record:wrong version number:../deps/openssl/openssl/ssl/record/ssl3_record.c:354:
npm error
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-16T11_40_42_588Z-debug-0.log

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17b1bc0 and 16b480d.

📒 Files selected for processing (1)

• src/dashboard/Data/Browser/DataBrowser.react.js (6 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/dashboard/Data/Browser/DataBrowser.react.js

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Docker linux/amd64

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[parse-github-assistant]

The label codex cannot be used here.

[parseplatformorg]

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (4)

src/dashboard/Data/Browser/DataBrowser.react.js (4)

83-88: Extract localStorage access logic to reduce duplication.

The localStorage access and aggregation checking logic is repeated in multiple methods. Consider extracting this into a helper method.

+  getStoredPanelVisibility() {
+    try {
+      return window.localStorage?.getItem(AGGREGATION_PANEL_VISIBLE) === 'true';
+    } catch {
+      return false;
+    }
+  }
+
+  hasAggregationForClass(className) {
+    return !!this.props.classwiseCloudFunctions?.[
+      `${this.props.app.applicationId}${this.props.appName}`
+    ]?.[className];
+  }

Then use these helpers in the constructor:

-    const storedPanelVisible =
-      window.localStorage?.getItem(AGGREGATION_PANEL_VISIBLE) === 'true';
-    const hasAggregation =
-      props.classwiseCloudFunctions?.[
-        `${props.app.applicationId}${props.appName}`
-      ]?.[props.className];
+    const storedPanelVisible = this.getStoredPanelVisibility();
+    const hasAggregation = this.hasAggregationForClass(props.className);

---

167-178: Apply DRY principle: Use helper methods for repeated logic.

This duplicates the localStorage access and aggregation checking logic from the constructor.

Using the helper methods suggested earlier:

-      const storedPanelVisible =
-        window.localStorage?.getItem(AGGREGATION_PANEL_VISIBLE) === 'true';
-      const hasAggregation =
-        props.classwiseCloudFunctions?.[
-          `${props.app.applicationId}${props.appName}`
-        ]?.[props.className];
+      const storedPanelVisible = this.getStoredPanelVisibility();
+      const hasAggregation = this.hasAggregationForClass(props.className);

---

256-285: Improve error handling and state management consistency.

The method correctly persists the new state but has a few areas for improvement:

1. The localStorage error handling is good but could be more consistent
2. Consider batching setState calls for better performance

 togglePanelVisibility() {
   const newVisibility = !this.state.isPanelVisible;
-  this.setState({ isPanelVisible: newVisibility });
   try {
     window.localStorage?.setItem(
       AGGREGATION_PANEL_VISIBLE,
       newVisibility
     );
   } catch {
     // ignore
   }

+  const stateUpdates = { isPanelVisible: newVisibility };
+  
   if (!newVisibility) {
     this.props.setAggregationPanelData({});
     this.props.setLoadingInfoPanel(false);
     if (this.props.errorAggregatedData != {}) {
       this.props.setErrorAggregatedData({});
     }
   }

+  this.setState(stateUpdates);
+
   if (!newVisibility && this.state.selectedObjectId) {
     if (this.props.errorAggregatedData != {}) {
       this.props.setErrorAggregatedData({});
     }
     this.props.callCloudFunction(
       this.state.selectedObjectId,
       this.props.className,
       this.props.app.applicationId
     );
   }
 }

---

308-316: Apply DRY principle: Use helper methods for repeated logic.

This is the third occurrence of the same localStorage access and aggregation checking logic.

Using the helper methods:

-      const storedPanelVisible =
-        window.localStorage?.getItem(AGGREGATION_PANEL_VISIBLE) === 'true';
-      const hasAggregation =
-        this.props.classwiseCloudFunctions?.[
-          `${this.props.app.applicationId}${this.props.appName}`
-        ]?.[className];
+      const storedPanelVisible = this.getStoredPanelVisibility();
+      const hasAggregation = this.hasAggregationForClass(className);

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4cbda1 and 17b1bc0.

📒 Files selected for processing (1)

• src/dashboard/Data/Browser/DataBrowser.react.js (6 hunks)

🧰 Additional context used

🧠 Learnings (1)

src/dashboard/Data/Browser/DataBrowser.react.js (1)

Learnt from: mtrezza
PR: parse-community/parse-dashboard#2828
File: src/dashboard/Data/Browser/Browser.react.js:1605-1607
Timestamp: 2025-05-27T12:09:47.644Z
Learning: In script execution dialogs in Parse Dashboard (specifically the `confirmExecuteScriptRows` method in `src/dashboard/Data/Browser/Browser.react.js`), individual `setState` calls to update `processedScripts` counter should be kept as-is rather than batched, because this provides real-time progress feedback to users in the dialog UI.

🔇 Additional comments (2)

src/dashboard/Data/Browser/DataBrowser.react.js (2)

22-22: LGTM: Good practice using constants for localStorage keys.

The constant follows the existing pattern and improves maintainability.

---

98-98: LGTM: Correct logic for initial panel visibility.

The panel is only shown when both the user preference is stored as true AND aggregation functions are available for the class.

[parseplatformorg]

🎉 This change has been released in version 7.3.0-alpha.16