feat: Allow editing filter without loading data in data browser #2949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Thanks for opening this pull request! |
📝 Walkthrough""" WalkthroughThis update introduces URL-driven filter editing in the browser view. It adds support for an Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Sidebar (CategoryList)
participant Browser
participant BrowserFilter
User->>Sidebar (CategoryList): Clicks edit icon on filter
Sidebar (CategoryList)->>Browser: onEditFilter(className, filterData)
Browser->>Browser: editFilter(className, filterData)
Browser->>Browser: Update URL with editFilter=true & filter data
Browser->>BrowserFilter: Renders with editFilter param
BrowserFilter->>BrowserFilter: Opens filter dialog in edit mode
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/components/BrowserFilter/BrowserFilter.react.js(7 hunks)src/components/BrowserFilter/FilterRow.react.js(1 hunks)src/components/CategoryList/CategoryList.react.js(4 hunks)src/components/CategoryList/CategoryList.scss(3 hunks)src/dashboard/Data/Browser/Browser.react.js(5 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (2)
src/components/BrowserFilter/FilterRow.react.js (1)
src/components/DateTimeEntry/DateTimeEntry.react.js (1)
focus(91-93)
src/components/BrowserFilter/BrowserFilter.react.js (1)
src/lib/ClassPreferences.js (1)
preferences(44-44)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Docker linux/amd64
🔇 Additional comments (12)
src/components/BrowserFilter/FilterRow.react.js (1)
119-129: Excellent fix for preventing unwanted calendar popups during filter editing.The conditional logic correctly identifies
DateTimeEntrycomponents by checking for bothfocusandopenmethods, and appropriately skips auto-focus to prevent the calendar from opening automatically when editing filters with date fields. The implementation is clean and targeted.src/dashboard/Data/Browser/Browser.react.js (4)
231-231: LGTM - Standard method binding.The binding follows the established pattern in the constructor.
492-524: Well-implemented edit filter mode handling.The logic correctly:
- Detects edit filter mode from URL parameters
- Sets empty data array to avoid loading states
- Conditionally skips expensive data fetching
- Preserves existing behavior for normal operation
This efficiently enables filter editing without unnecessary data loading.
1385-1403: Clean implementation of filter editing navigation.The method properly:
- Constructs URLs with appropriate filter parameters
- Handles optional filterId for modern filters
- Uses consistent navigation patterns
- Enables edit mode through URL parameters
The implementation supports the core feature requirement effectively.
2233-2233: LGTM - Proper callback prop connection.Correctly passes the
editFiltermethod to enable UI-triggered filter editing from the category list.src/components/CategoryList/CategoryList.react.js (4)
143-150: Good UI structure improvement.Separating the category name in the link from the count display creates cleaner component structure and enables better styling control.
162-162: LGTM - Complementary count display separation.The separate count span with dedicated styling class supports the improved component structure.
193-203: Well-implemented filter edit affordance.The conditional edit icon properly:
- Renders only when callback is provided
- Prevents default link behavior
- Passes correct parameters to the callback
- Provides clear visual editing cue
221-221: LGTM - Proper PropTypes documentation.The PropTypes addition correctly documents the onEditFilter callback function.
src/components/CategoryList/CategoryList.scss (3)
56-56: LGTM - Layout adjustment for new structure.The margin change from right to left aligns with the updated flexbox layout that accommodates the separated count display.
65-106: Comprehensive styling support for component restructuring.The CSS changes effectively support the new UI structure:
- Center alignment improves visual consistency
- Text truncation prevents layout breaking with long names
- Count styling maintains design system consistency
- Edit icon hover effects provide clear interaction feedback
Well-implemented responsive design considerations.
124-143: Consistent filter edit icon styling.The .editFilter styles maintain design consistency with the main edit icon, providing uniform interaction patterns and visual feedback throughout the component hierarchy.
parseplatformorg
pushed a commit
that referenced
this pull request
Jul 27, 2025
# [7.3.0-alpha.38](7.3.0-alpha.37...7.3.0-alpha.38) (2025-07-27) ### Features * Allow editing filter without loading data in data browser ([#2949](#2949)) ([9623580](9623580))
|
🎉 This change has been released in version 7.3.0-alpha.38 |
parseplatformorg
pushed a commit
that referenced
this pull request
Aug 1, 2025
# [7.3.0](7.2.1...7.3.0) (2025-08-01) ### Bug Fixes * Changing "Relative dates" option of saved filter does not enable save button ([#2947](#2947)) ([4f4977d](4f4977d)) * Class object counters in sidebar not updating ([#2950](#2950)) ([0f1920b](0f1920b)) * Clicking linked pointer with Cmd key in view table doesn't open page in new browser tab ([#2902](#2902)) ([101b194](101b194)) * Fails to generate MFA code with CLI command `parse-dashboard --createMFA` ([#2883](#2883)) ([544df1f](544df1f)) * Gracefully fail when trying to get new features in latest version of dashboard ([#2880](#2880)) ([1969a0e](1969a0e)) * Header checkbox in data browser does not indicate when a few rows are selected ([#2957](#2957)) ([e4ab666](e4ab666)) * Hyperlink in Views table ignores `urlQuery` key ([#2926](#2926)) ([c5eedf4](c5eedf4)) * Incorrect table cell width in App Settings table ([#2933](#2933)) ([d46765b](d46765b)) * Info panel scroll-to-top setting not persistent across dashboard sessions ([#2938](#2938)) ([2b78087](2b78087)) * Invalid clipboard content for multi-cell copy in data browser ([#2882](#2882)) ([22a2065](22a2065)) * Legacy filters without `filterId` cannot be deleted in data browser ([#2946](#2946)) ([65df9d6](65df9d6)) * Legacy filters without `filterId` do not appear in sidebar ([#2945](#2945)) ([fde3769](fde3769)) * Modal text input can be resized smaller than its cell in Safari browser ([#2930](#2930)) ([82a0cdc](82a0cdc)) * Move settings button on data browser toolbar for better UI ([#2940](#2940)) ([c473ce6](c473ce6)) * Pagination footer bar hides rows in data browser ([#2879](#2879)) ([6bc2da8](6bc2da8)) * Race condition on info panel request shows info panel data not corresponding to selected cell ([#2909](#2909)) ([6f45bb3](6f45bb3)) * Saved legacy filter in data browser cannot be deleted or cloned ([#2944](#2944)) ([15da90d](15da90d)) * Saved legacy filter with classname in query cannot be deleted ([#2948](#2948)) ([05ee5b3](05ee5b3)) * Selected text in info panel cannot be copied using Ctrl+C ([#2951](#2951)) ([0164c19](0164c19)) * Views not sorted alphabetically in sidebar ([#2943](#2943)) ([4c81fe4](4c81fe4)) * Warning dialog is shown after executing script on selected rows ([#2899](#2899)) ([027f1ed](027f1ed)) ### Features * Add additional values in info panel key-value element ([#2904](#2904)) ([a8f110e](a8f110e)) * Add AI agent for natural language interaction with Parse Server ([#2954](#2954)) ([32bd6e8](32bd6e8)) * Add clipboard icon to copy value of key-value element in info panel ([#2871](#2871)) ([7862c42](7862c42)) * Add Cloud Function as data source for views with optional text or file upload ([#2939](#2939)) ([f5831c7](f5831c7)) * Add column freezing in data browser ([#2877](#2877)) ([29f4a88](29f4a88)) * Add custom data views with aggregation query ([#2888](#2888)) ([b1679db](b1679db)) * Add environment variable support for AI agent configuration ([#2956](#2956)) ([2ac9e7e](2ac9e7e)) * Add hyperlink support in Views table ([#2925](#2925)) ([06cfc11](06cfc11)) * Add inclusive date filters "is on or after", "is on or before" in data browser ([#2929](#2929)) ([c8d621b](c8d621b)) * Add quick-add button to array parameter in Cloud Config ([#2866](#2866)) ([e98ccb2](e98ccb2)) * Add row number column to data browser ([#2878](#2878)) ([c0aa407](c0aa407)) * Add Settings menu to scroll info panel to top when browsing through rows ([#2937](#2937)) ([f339cb8](f339cb8)) * Add support for "not equal to" filter for Boolean values in data browser and analytics explorer ([#2914](#2914)) ([d55b89c](d55b89c)) * Add support for `Image` type in View table to display images ([#2952](#2952)) ([6a6b1f0](6a6b1f0)) * Add type mismatch warning when quick-adding entry to Cloud Config array parameter ([#2875](#2875)) ([bb1837f](bb1837f)) * Add view edit icon to views list in sidebar ([#2901](#2901)) ([96e33b9](96e33b9)) * Allow editing filter without loading data in data browser ([#2949](#2949)) ([9623580](9623580)) * Allow editing saved filters in data browser ([#2942](#2942)) ([daaccaa](daaccaa)) * Allow freeform text view resizing in modal dialogs ([#2910](#2910)) ([1399162](1399162)) * Persist info panel visibility when navigating across classes in data browser ([#2908](#2908)) ([1a3610a](1a3610a)) * Prefetch info panel data with config options `prefetchObjects` and `prefetchStale` ([#2915](#2915)) ([54a8156](54a8156)) * Warn when leaving data browser page with selected rows ([#2887](#2887)) ([206ead1](206ead1)) ### Performance Improvements * Add config option `enableResourceCache` to cache dashboard resources locally for faster loading in additional browser tabs ([#2920](#2920)) ([41a4963](41a4963))
beiguancyc
pushed a commit
to beiguancyc/parse-dashboard
that referenced
this pull request
Aug 3, 2025
* release: (124 commits) chore(release): 7.3.0 [skip ci] empty commit to trigger CI refactor: Bump prettier from 3.5.3 to 3.6.2 (parse-community#2955) chore(release): 7.3.0-alpha.44 [skip ci] feat: Add environment variable support for AI agent configuration (parse-community#2956) chore(release): 7.3.0-alpha.43 [skip ci] fix: Header checkbox in data browser does not indicate when a few rows are selected (parse-community#2957) refactor: Bump jest-environment-jsdom from 30.0.4 to 30.0.5 (parse-community#2941) chore(release): 7.3.0-alpha.42 [skip ci] feat: Add AI agent for natural language interaction with Parse Server (parse-community#2954) chore(release): 7.3.0-alpha.41 [skip ci] feat: Add support for `Image` type in View table to display images (parse-community#2952) chore(release): 7.3.0-alpha.40 [skip ci] fix: Selected text in info panel cannot be copied using Ctrl+C (parse-community#2951) chore(release): 7.3.0-alpha.39 [skip ci] fix: Class object counters in sidebar not updating (parse-community#2950) chore(release): 7.3.0-alpha.38 [skip ci] feat: Allow editing filter without loading data in data browser (parse-community#2949) chore(release): 7.3.0-alpha.37 [skip ci] fix: Saved legacy filter with classname in query cannot be deleted (parse-community#2948) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is especially useful if a filter has a resource intensive query. In order to edit or delete it, it should not be necessary to execute a filter query first.
Summary by CodeRabbit
New Features
Bug Fixes
Style