-
-
Notifications
You must be signed in to change notification settings - Fork 153
fix: remove redundant part from alert notification message #1439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove redundant part from alert notification message #1439
Conversation
duplicate entries in message - 1. AlertName 2. Triggered TimeStamp 3. Severity
WalkthroughRemoved Context::default_alert_string from alert_structs and updated webhook targets to use payload.message directly for Triggered alerts. This changes the exact message content sent to Slack and other webhooks without altering control flow or public APIs. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant A as Alert Producer
participant C as Context
participant P as Payload
participant W as Webhook (Slack/Other)
A->>C: Build Context
A->>P: Create Payload (message)
note over P: message now used directly
A->>W: Send Triggered alert with P.message
W-->>A: Response (success/error)
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
🔇 Additional comments (2)
Comment |
duplicate entries in message -
Summary by CodeRabbit