Skip to content

fix: remove redundant part from alert notification message #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

fix: remove redundant part from alert notification message #1439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
305a6a0
fix: remove redundant part from alert notification message
nikhilsinhaparseable Sep 24, 2025
e33948b
Merge branch 'main' into fix-alert-message
nikhilsinhaparseable Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/alerts/alert_structs.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,6 @@ impl Context {
}
}

pub(crate) fn default_alert_string(&self) -> String {
format!(
"AlertName: {}\nTriggered TimeStamp: {}\nSeverity: {}\n{}",
self.alert_info.alert_name,
Utc::now().to_rfc3339(),
self.alert_info.severity,
self.message
)
}

pub(crate) fn default_resolved_string(&self) -> String {
format!("{} is now `not-triggered` ", self.alert_info.alert_name)
}
Expand Down
4 changes: 2 additions & 2 deletions src/alerts/target.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ impl CallableTarget for SlackWebHook {

let alert = match payload.alert_info.alert_state {
AlertState::Triggered => {
serde_json::json!({ "text": payload.default_alert_string() })
serde_json::json!({ "text": payload.message })
}
AlertState::NotTriggered => {
serde_json::json!({ "text": payload.default_resolved_string() })
Expand Down Expand Up @@ -476,7 +476,7 @@ impl CallableTarget for OtherWebHook {
.expect("Client can be constructed on this system");

let alert = match payload.alert_info.alert_state {
AlertState::Triggered => payload.default_alert_string(),
AlertState::Triggered => payload.message.clone(),
AlertState::NotTriggered => payload.default_resolved_string(),
AlertState::Disabled => payload.default_disabled_string(),
};
Expand Down
Loading