Skip to content

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Feb 13, 2024

What: Closes #10001, #9919

This bumps the core alpha version to 6.0.0-alpha.84.
Adjustments to fix the build:

  • TreeViewListItem selectable modifier removed, using a string now.
  • Menu favorite, nav, text, focus modifiers removed, using a string now. focus should probably be added back.
  • CalendarMonth prevMonth and nextMonth modifiers removed, using a string now.

The PR updates CodeEditor with penta changes, and fixes an example for vertical Divider after the core-side Divider fix went in. TreeView, Menu, CalendarMonth are not verified other than build fixes.

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 13, 2024

@tlabaj tlabaj requested review from a team, andrew-ronaldson, lboehling, mattnolting, mfrances17 and wise-king-sullyman and removed request for a team February 13, 2024 19:59
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merçi!

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐷👍

Copy link
Contributor

@mfrances17 mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@tlabaj tlabaj merged commit addda04 into patternfly:v6 Feb 16, 2024
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consume core Penta updates: Code editor Consume core Penta updates: Divider

7 participants