-
Notifications
You must be signed in to change notification settings - Fork 370
feat(CodeEditor,Divider): consume penta & update core version #10081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview: https://patternfly-react-pr-10081.surge.sh A11y report: https://patternfly-react-pr-10081-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merçi!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐷👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Your changes have been released in:
Thanks for your contribution! 🎉 |
What: Closes #10001, #9919
This bumps the core alpha version to
6.0.0-alpha.84
.Adjustments to fix the build:
TreeViewListItem
selectable
modifier removed, using a string now.Menu
favorite
,nav
,text
,focus
modifiers removed, using a string now.focus
should probably be added back.CalendarMonth
prevMonth
andnextMonth
modifiers removed, using a string now.The PR updates
CodeEditor
with penta changes, and fixes an example for verticalDivider
after the core-side Divider fix went in.TreeView
,Menu
,CalendarMonth
are not verified other than build fixes.