Skip to content

Develop --> Main sync #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 22, 2024
Merged

Develop --> Main sync #541

merged 24 commits into from
Nov 22, 2024

Conversation

Hugo0
Copy link
Contributor

@Hugo0 Hugo0 commented Nov 22, 2024

No description provided.

jjramirezn and others added 24 commits November 19, 2024 21:12
@jjramirezn
feat: populate tokenSelector with squid tokens
2c33429
@jjramirezn
chore: bump peanut-sdk
70faf52
@jjramirezn
feat(token-selector): conditionaly show supported tokens
e236ad5 
Per flow we only want to show tokens that make sense,
for example if we are paying we dont want to show tokens that
are not supported by squid.
@jjramirezn
feat(request): dont show token selector if token doesnt support xchain
8d56264
@jjramirezn
Merge branch 'develop' into feat/xchain-show-only-viable-tokens
70a1985
@jjramirezn
fix(claim): error on iban for non xchain tokens
bc821fb
@jjramirezn
refactor: use promise all in getSquidChainsAndTokens
e2a88b3
@jjramirezn
refactor(create-link): add missing optional chaining
3ae06d6
@jjramirezn
Merge branch 'develop' into feat/xchain-show-only-viable-tokens
ba54373
@jjramirezn
style: run prettier
faeefa1
@jjramirezn
feat: clearer copy on claim confirm
1fe6c2f
@jjramirezn
fix(token-selector): selectBalance directly when selecting token
fb27dbb
@jjramirezn
fix(token-selector): ensure chain icon is shown
8468cb1
@jjramirezn
fix(token-selector): correctly reset
2ecf908
@jjramirezn
fix(claim): correctly reset selected chain and token
205bd10
@jjramirezn
feat: better chain selector
c0f3f34 
Smoother transition, make search bar sticky
@jjramirezn
fix(create-link): correctly load token details on confirm
58b131c
@jjramirezn
feat(claim): hide token selector for non-xchain tokens
76dcc8b
@jjramirezn
feat: sync balances array with connection status
e78d761
@jjramirezn
fix(token-selector): show not supported token name even when disconnectd
5c11fa6
@jjramirezn
feat(token-selector): dont show balance if not connected
1295578
@jjramirezn
fix(token-selector): set token symbol when present
f66c156
@jjramirezn
fix(request): use correct chain for same chain payments
b6d437c
@Hugo0
Merge pull request #539 from peanutprotocol/feat/xchain-show-only-via…
2fc06ec 
…ble-tokens

[TASK-6955] feat: populate token selector with squid supported token
@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
peanut-ui 🔄 Building (Inspect) Visit Preview ✅ 1 resolved Nov 22, 2024 7:35am

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 22, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request introduces several changes across multiple files, primarily focusing on enhancing error handling, logging, and data management related to token selection and cross-chain functionality. Key modifications include the addition of a beforeSend function in the Sentry configuration to filter sensitive headers, the introduction of caching mechanisms for squid chains and tokens, and updates to various components to streamline user interactions and improve data handling. Additionally, several state variables and properties have been added or removed to refine the overall architecture of the application.

Changes

File Path Change Summary
sentry.edge.config.ts Added a beforeSend function to filter out sensitive request headers before sending events to Sentry; removed unnecessary blank lines.
src/app/actions/squid.ts Introduced caching functions for squid chains and tokens, along with a main function that returns supported chains and their tokens.
src/components/Claim/Claim.consts.ts Removed crossChainDetails property from IClaimScreenProps interface.
src/components/Claim/Claim.tsx Removed crossChainDetails state variable and associated logic; updated checkLink function to eliminate cross-chain handling.
src/components/Claim/Generic/AlreadyClaimed.view.tsx Removed unused useRouter import and related routing logic, simplifying the component.
src/components/Claim/Link/Initial.view.tsx Added supportedSquidChainsAndTokens state variable; updated logic for token compatibility checks and rendering messages based on token support.
src/components/Claim/Link/Onchain/Confirm.view.tsx Enhanced component to utilize supportedSquidChainsAndTokens for displaying relevant chain information; refined error handling.
src/components/Create/Link/Confirm.view.tsx Updated imports and utilized memoization for selected chain and token; improved error handling and rendering logic.
src/components/Global/ChainSelector/index.tsx Made structural and stylistic adjustments to improve dropdown menu layout and presentation.
src/components/Global/ConfirmDetails/Index.tsx Updated IConfirmDetailsProps interface to include new properties for token and chain details; simplified rendering logic.
src/components/Global/TokenSelector/Components/AdvancedButton.tsx Added connection status handling to reset token balance; introduced _tokenSymbol state for managing token symbol fetching.
src/components/Global/TokenSelector/TokenSelector.consts.ts Added new optional property showOnlySquidSupported to TokenSelectorProps interface.
src/components/Global/TokenSelector/TokenSelector.tsx Reorganized imports; enhanced token list with new context value; introduced filtering based on showOnlySquidSupported prop.
src/components/Request/Pay/Views/Initial.view.tsx Added state variable for supported squid chains and tokens; updated logic for displaying token selection messages and switching networks.
src/context/tokenSelector.context.tsx Enhanced context provider to include supportedSquidChainsAndTokens and updated state management for token selection.
src/hooks/useBalance.tsx Updated to handle user connection status; added logic to clear balances when disconnected and refetch balances when connected.

Possibly related PRs

Suggested reviewers

  • jjramirezn

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Hugo0 Hugo0 merged commit b9ebe54 into main Nov 22, 2024
2 of 3 checks passed
This was referenced Nov 24, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 2, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hugo0 @jjramirezn