Skip to content

docs(component): added missing components to components page #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

joesphchang
Copy link

Issue: #3986
Changes I made

Utilized given screenshot to update components page.
Uploaded given photos into icons folder
Rearranged components page and wrote out description.

renovate bot and others added 13 commits July 3, 2025 09:48
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@joesphchang
Copy link
Author

Ok - I tried doing the way we did it before Perry but all the other commits stayed.

Copy link
Owner

@perrygovier perrygovier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left a few minor notes.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This will be a big improvement to that landing page. I left a few notes about some of the descriptions.

I'm open to discussion if you prefer to keep any of them as you have them.

Either way, after you make the changes, feel free to send this on to Ionic. If the PR includes other commits, back out, and let's try it together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants