forked from ionic-team/ionic-docs
-
Notifications
You must be signed in to change notification settings - Fork 0
docs(component): added missing components to components page #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joesphchang
wants to merge
17
commits into
perrygovier:main
Choose a base branch
from
joesphchang:missing-components-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
4f29868
chore(deps): update ionic to v8.6.3 (#4173)
renovate[bot] 10e2827
chore(deps): update dependency @types/node to v22.15.34 (#4171)
renovate[bot] d9ffaf6
docs(theming): fix broken link in high contrast mode guide (#4174)
minhperry 9f1709f
chore(deps): update dependency vite to v7.0.2 (#4177)
renovate[bot] 281b4ad
chore(deps): update dependency @types/node to v22.16.0 (#4178)
renovate[bot] 16e4fcd
chore(deps): update dependency ionicons to v8.0.10 (#4175)
renovate[bot] 1b10677
chore(deps): update dependency vite to v7.0.2 (#4176)
renovate[bot] a9e9a27
docs(refresher): use `RefresherCustomEvent` type in playground exampl…
ace-of-aces 4161fad
refactor(stackblitz): move html playgrounds to node and vite (#4062)
brandyscarney 3412819
docs(contributing): update toc (#4181)
brandyscarney 9f63609
chore(deps): update dependency vite to v7 (#4182)
renovate[bot] a796d68
docs(config): add playground examples of how to access the mode per f…
joesphchang 9955fd4
docs(component): added missing components
joesphchang d4c5cda
docs(components): updated descriptions on components
joesphchang 966245b
docs(components): made suggested changes to file
joesphchang d1e2192
docs(components): ran npm run lint
joesphchang f14a37c
docs: icon -> icons
brandyscarney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,19 @@ | ||
<html> | ||
<!DOCTYPE html> | ||
<html lang="en"> | ||
|
||
<head> | ||
<link rel="stylesheet" type="text/css" href="https://cdn.skypack.dev/@ionic/core@7/css/core.css" /> | ||
<link rel="stylesheet" type="text/css" href="https://cdn.skypack.dev/@ionic/core@7/css/ionic.bundle.css" /> | ||
<meta charset="UTF-8" /> | ||
<link rel="icon" href="/favicon.ico" /> | ||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
<title>Ionic App</title> | ||
</head> | ||
|
||
<body> | ||
<ion-app> | ||
{{ TEMPLATE }} | ||
</ion-app> | ||
|
||
<script type="module" src="./index.ts"></script> | ||
</body> | ||
|
||
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,20 @@ | ||
{ | ||
"name": "html-starter", | ||
"private": true, | ||
"type": "module", | ||
"main": "index.ts", | ||
"scripts": { | ||
"dev": "vite", | ||
"build": "vite build", | ||
"start": "vite preview" | ||
}, | ||
"dependencies": { | ||
"@ionic/core": "^7.0.0", | ||
"ionicons": "8.0.9" | ||
"ionicons": "8.0.10" | ||
}, | ||
"devDependencies": { | ||
"typescript": "^5.0.0", | ||
"vite": "^7.0.0", | ||
"vite-plugin-static-copy": "^3.1.0" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"compilerOptions": { | ||
"baseUrl": "./", | ||
"target": "esnext", | ||
"module": "nodenext", | ||
"moduleResolution": "nodenext", | ||
"outDir": "dist", | ||
"strict": true, | ||
"esModuleInterop": true, | ||
"skipLibCheck": true, | ||
"forceConsistentCasingInFileNames": true, | ||
"lib": ["esnext", "dom"], | ||
"resolveJsonModule": true, | ||
"allowSyntheticDefaultImports": true, | ||
"isolatedModules": true, | ||
"types": ["node"] | ||
}, | ||
"include": ["src/**/*.ts"] | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! This will be a big improvement to that landing page. I left a few notes about some of the descriptions.
I'm open to discussion if you prefer to keep any of them as you have them.
Either way, after you make the changes, feel free to send this on to Ionic. If the PR includes other commits, back out, and let's try it together.